From 6f580b452459138fb0e567ee8730543fe702272c Mon Sep 17 00:00:00 2001 From: Akaonetwo <107335783+Akare123@users.noreply.github.com> Date: Sun, 5 Jan 2025 06:02:40 +0300 Subject: [PATCH] Typo fixed in: Update README.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi, I suggest two grammatical changes for this text: First one: "it's" vs. "its": "Each peer/node on the network is identified via it's ENR..." → "Each peer/node on the network is identified via its ENR..." Explanation: "It's" is a contraction of "it is," whereas "its" is the possessive form. Second one: "PING/PONG's": "through regular PING/PONG's with discovered nodes." → "through regular PING/PONGs with discovered nodes." Explanation: "PING/PONGs" should not have an apostrophe since it refers to a plural form, not possession. Thanks and a happy new year. --- version-meld/discv5/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/version-meld/discv5/README.md b/version-meld/discv5/README.md index 21934ee0..7491dcc2 100644 --- a/version-meld/discv5/README.md +++ b/version-meld/discv5/README.md @@ -20,12 +20,12 @@ This is a rust implementation of the [Discovery v5](https://github.com/ethereum/ peer discovery protocol. Discovery v5 is a protocol designed for encrypted peer discovery and topic advertisement. Each peer/node -on the network is identified via it's `ENR` ([Ethereum Node +on the network is identified via its `ENR` ([Ethereum Node Record](https://eips.ethereum.org/EIPS/eip-778)), which is essentially a signed key-value store containing the node's public key and optionally IP address and port. Discv5 employs a kademlia-like routing table to store and manage discovered peers and topics. The -protocol allows for external IP discovery in NAT environments through regular PING/PONG's with +protocol allows for external IP discovery in NAT environments through regular PING/PONGs with discovered nodes. Nodes return the external IP address that they have received and a simple majority is chosen as our external IP address. If an external IP address is updated, this is produced as an event to notify the swarm (if one is used for this behaviour).