From 106c500d0a4668f5b4363f25151fe42dfb5e8bf4 Mon Sep 17 00:00:00 2001
From: Sean McArthur <sean@seanmonstar.com>
Date: Fri, 20 Oct 2023 13:50:48 -0400
Subject: [PATCH] fix(http2): change default server max concurrent streams to
 200 (#3362)

Closes #3358

BREAKING CHANGE: This is a behavioral change. Consider setting your own
  maximum.
---
 src/proto/h2/server.rs   |  2 +-
 src/server/conn/http2.rs | 11 ++++-------
 2 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/src/proto/h2/server.rs b/src/proto/h2/server.rs
index 0337e22ea8..12103c3a58 100644
--- a/src/proto/h2/server.rs
+++ b/src/proto/h2/server.rs
@@ -62,7 +62,7 @@ impl Default for Config {
             initial_stream_window_size: DEFAULT_STREAM_WINDOW,
             max_frame_size: DEFAULT_MAX_FRAME_SIZE,
             enable_connect_protocol: false,
-            max_concurrent_streams: None,
+            max_concurrent_streams: Some(200),
             keep_alive_interval: None,
             keep_alive_timeout: Duration::from_secs(20),
             max_send_buffer_size: DEFAULT_MAX_SEND_BUF_SIZE,
diff --git a/src/server/conn/http2.rs b/src/server/conn/http2.rs
index e412f0001f..1af3d4a36e 100644
--- a/src/server/conn/http2.rs
+++ b/src/server/conn/http2.rs
@@ -177,7 +177,10 @@ impl<E> Builder<E> {
     /// Sets the [`SETTINGS_MAX_CONCURRENT_STREAMS`][spec] option for HTTP2
     /// connections.
     ///
-    /// Default is no limit (`std::u32::MAX`). Passing `None` will do nothing.
+    /// Default is 200, but not part of the stability of hyper. It could change
+    /// in a future release. You are encouraged to set your own limit.
+    ///
+    /// Passing `None` will remove any limit.
     ///
     /// [spec]: https://httpwg.org/specs/rfc9113.html#SETTINGS_MAX_CONCURRENT_STREAMS
     pub fn max_concurrent_streams(&mut self, max: impl Into<Option<u32>>) -> &mut Self {
@@ -191,9 +194,6 @@ impl<E> Builder<E> {
     /// Pass `None` to disable HTTP2 keep-alive.
     ///
     /// Default is currently disabled.
-    ///
-    /// # Cargo Feature
-    ///
     pub fn keep_alive_interval(&mut self, interval: impl Into<Option<Duration>>) -> &mut Self {
         self.h2_builder.keep_alive_interval = interval.into();
         self
@@ -205,9 +205,6 @@ impl<E> Builder<E> {
     /// be closed. Does nothing if `keep_alive_interval` is disabled.
     ///
     /// Default is 20 seconds.
-    ///
-    /// # Cargo Feature
-    ///
     pub fn keep_alive_timeout(&mut self, timeout: Duration) -> &mut Self {
         self.h2_builder.keep_alive_timeout = timeout;
         self