Skip to content

Commit 372af98

Browse files
committed
fix(namespace-tabs): remove remoteNamespaces computed property and use namespaces directly in tab rendering
1 parent 6de168c commit 372af98

File tree

2 files changed

+5
-16
lines changed

2 files changed

+5
-16
lines changed

app/components.d.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ declare module 'vue' {
1717
ABreadcrumbItem: typeof import('ant-design-vue/es')['BreadcrumbItem']
1818
AButton: typeof import('ant-design-vue/es')['Button']
1919
ACard: typeof import('ant-design-vue/es')['Card']
20-
ACheckbox: typeof import('ant-design-vue/es')['Checkbox']
21-
ACheckboxGroup: typeof import('ant-design-vue/es')['CheckboxGroup']
2220
ACol: typeof import('ant-design-vue/es')['Col']
2321
ACollapse: typeof import('ant-design-vue/es')['Collapse']
2422
ACollapsePanel: typeof import('ant-design-vue/es')['CollapsePanel']
@@ -46,23 +44,22 @@ declare module 'vue' {
4644
APopover: typeof import('ant-design-vue/es')['Popover']
4745
AppProviderAppProvider: typeof import('./src/components/AppProvider/AppProvider.vue')['default']
4846
AProgress: typeof import('ant-design-vue/es')['Progress']
49-
ARangePicker: typeof import('ant-design-vue/es')['RangePicker']
47+
AResult: typeof import('ant-design-vue/es')['Result']
5048
ARow: typeof import('ant-design-vue/es')['Row']
51-
ASegmented: typeof import('ant-design-vue/es')['Segmented']
5249
ASelect: typeof import('ant-design-vue/es')['Select']
5350
ASelectOption: typeof import('ant-design-vue/es')['SelectOption']
5451
ASpace: typeof import('ant-design-vue/es')['Space']
5552
AStatistic: typeof import('ant-design-vue/es')['Statistic']
53+
AStep: typeof import('ant-design-vue/es')['Step']
54+
ASteps: typeof import('ant-design-vue/es')['Steps']
5655
ASubMenu: typeof import('ant-design-vue/es')['SubMenu']
5756
ASwitch: typeof import('ant-design-vue/es')['Switch']
58-
ATable: typeof import('ant-design-vue/es')['Table']
5957
ATabPane: typeof import('ant-design-vue/es')['TabPane']
6058
ATabs: typeof import('ant-design-vue/es')['Tabs']
6159
ATag: typeof import('ant-design-vue/es')['Tag']
6260
ATextarea: typeof import('ant-design-vue/es')['Textarea']
6361
ATooltip: typeof import('ant-design-vue/es')['Tooltip']
6462
ATypographyText: typeof import('ant-design-vue/es')['TypographyText']
65-
ATypographyTitle: typeof import('ant-design-vue/es')['TypographyTitle']
6663
AutoCertFormAutoCertForm: typeof import('./src/components/AutoCertForm/AutoCertForm.vue')['default']
6764
AutoCertFormDNSChallenge: typeof import('./src/components/AutoCertForm/DNSChallenge.vue')['default']
6865
BaseEditorBaseEditor: typeof import('./src/components/BaseEditor/BaseEditor.vue')['default']

app/src/components/NamespaceTabs/NamespaceTabs.vue

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,6 @@ const currentNamespace = computed(() => {
5656
return namespaces.value.find(g => g.id === Number(modelValue.value))
5757
})
5858
59-
// Filter namespaces for remote tabs
60-
const remoteNamespaces = computed(() => {
61-
return namespaces.value.filter(ns =>
62-
ns.deploy_mode === 'remote'
63-
|| (ns.sync_node_ids && ns.sync_node_ids.length > 0),
64-
)
65-
})
66-
6759
// Get the list of nodes in the current group
6860
const syncNodes = computed(() => {
6961
if (!currentNamespace.value)
@@ -120,10 +112,10 @@ async function handleRestartNginx() {
120112

121113
<template>
122114
<div>
123-
<ATabs :active-key="modelValue" @update:active-key="modelValue = $event">
115+
<ATabs v-model:active-key="modelValue">
124116
<ATabPane :key="0" :tab="$gettext('Local')" />
125117
<ATabPane
126-
v-for="ns in remoteNamespaces"
118+
v-for="ns in namespaces"
127119
:key="ns.id"
128120
:tab="ns.name"
129121
/>

0 commit comments

Comments
 (0)