Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing deserialization of the Miden package #347

Closed
greenhat opened this issue Oct 21, 2024 · 1 comment
Closed

Failing deserialization of the Miden package #347

greenhat opened this issue Oct 21, 2024 · 1 comment
Labels
bug Something isn't working
Milestone
Beta 1

Comments

@greenhat
Copy link
Contributor

It could be related to the error discovered in #319 (comment)

The package parsing fails when parsing the masp file compiled in the build_new_project_from_template test.

The code to reproduce:

    let masp = Package::read_from_file(masp_path.clone()).unwrap();
@greenhat greenhat added the bug Something isn't working label Oct 21, 2024
@greenhat greenhat mentioned this issue Oct 21, 2024
Closed
@greenhat greenhat added this to the Beta 1 milestone Oct 21, 2024
greenhat added a commit to 0xPolygonMiden/miden-vm that referenced this issue Oct 30, 2024
@greenhat
fix: on Library deserialization, use unchecked constructor for proced…
6d81d65 
…ure names

The checked constructor fits when parsing MASM code.
The Miden package contains the export names crafted according to the Wasm CM naming scheme
i.e. `namespace:package/interface@version#function`.
Discovered in 0xPolygonMiden/compiler#347
when parsing the Miden package file of the basic wallet account code.
@greenhat greenhat mentioned this issue Oct 30, 2024
Merged
greenhat added a commit to 0xPolygonMiden/miden-vm that referenced this issue Oct 30, 2024
@greenhat
fix: on Library deserialization, use unchecked constructor for proced…
1ca8581 
…ure names

The checked constructor fits when parsing MASM code.
The Miden package contains the export names crafted according to the Wasm CM naming scheme
i.e. `namespace:package/interface@version#function`.
Discovered in 0xPolygonMiden/compiler#347
when parsing the Miden package file of the basic wallet account code.
greenhat added a commit to 0xPolygonMiden/miden-vm that referenced this issue Nov 4, 2024
@greenhat
fix: on Library deserialization, use unchecked constructor for proced…
3581727 
…ure names

The checked constructor fits when parsing MASM code.
The Miden package contains the export names crafted according to the Wasm CM naming scheme
i.e. `namespace:package/interface@version#function`.
Discovered in 0xPolygonMiden/compiler#347
when parsing the Miden package file of the basic wallet account code.
bobbinth pushed a commit to 0xPolygonMiden/miden-vm that referenced this issue Nov 4, 2024
@greenhat
fix: on Library deserialization, use unchecked constructor for proced…
e3fa9ec 
…ure names (#1554)

The checked constructor fits when parsing MASM code.
The Miden package contains the export names crafted according to the Wasm CM naming scheme
i.e. `namespace:package/interface@version#function`.
Discovered in 0xPolygonMiden/compiler#347
when parsing the Miden package file of the basic wallet account code.
@greenhat
Copy link
Contributor Author

greenhat commented Nov 5, 2024

Fixed in 0xPolygonMiden/miden-vm#1554

@greenhat greenhat closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Beta 1
Development

No branches or pull requests
1 participant
@greenhat