chore: remove unused code and dependencies

Author: greenhat

Cargo.lock

@@ -21,10 +21,6 @@ doctest = false
 default = ["std"]
 std = ["aho-corasick/std", "miette/fancy", "miette/std", "vm-core/std", "thiserror/std"]
 testing = ["dep:regex"]
-serde = [
-    "dep:serde",
-    "smallvec/serde",
-]
 
 [dependencies]
 aho-corasick = { version = "1.1", default-features = false }
@@ -41,7 +37,6 @@ unicode-width = { version = "0.2", features = ["no_std"] }
 vm-core = { package = "miden-core", path = "../core", version = "0.11", default-features = false, features = [
     "diagnostics",
 ] }
-serde = { version = "1.0.208", features = ["alloc", "rc", "serde_derive"], optional = true }
 
 [dev-dependencies]
 pretty_assertions = "1.4"

assembly/Cargo.toml

@@ -183,38 +183,3 @@ impl FromStr for Ident {
         Ok(Self { span: SourceSpan::default(), name })
     }
 }
-
-#[cfg(feature = "serde")]
-impl serde::Serialize for Ident {
-    fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
-    where
-        S: serde::Serializer,
-    {
-        self.as_str().serialize(serializer)
-    }
-}
-
-#[cfg(feature = "serde")]
-impl<'de> serde::Deserialize<'de> for Ident {
-    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
-    where
-        D: serde::Deserializer<'de>,
-    {
-        struct IdentVisitor;
-        impl serde::de::Visitor<'_> for IdentVisitor {
-            type Value = Ident;
-
-            fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
-                formatter.write_str("ident")
-            }
-
-            fn visit_str<E>(self, v: &str) -> Result<Self::Value, E>
-            where
-                E: serde::de::Error,
-            {
-                Ok(Ident::new_unchecked(Span::unknown(Arc::from(v))))
-            }
-        }
-        deserializer.deserialize_str(IdentVisitor)
-    }
-}

assembly/src/ast/ident.rs

@@ -92,6 +92,7 @@ impl Library {
         Ok(Self { digest, exports, mast_forest })
     }
 
+    /// Produces a new library with the existing [`MastForest`] and provided advice map.
     pub fn with_advice_map(self, advice_map: AdviceMap) -> Self {
         let mut mast_forest = (*self.mast_forest).clone();
         mast_forest.advice_map_mut().extend(advice_map);

assembly/src/library/mod.rs

@@ -55,6 +55,7 @@ impl Program {
         Self { mast_forest, entrypoint, kernel }
     }
 
+    /// Produces a new program with the existing [`MastForest`] and provided advice map.
     pub fn with_advice_map(self, advice_map: AdviceMap) -> Self {
         let mut mast_forest = (*self.mast_forest).clone();
         mast_forest.advice_map_mut().extend(advice_map);

core/src/program.rs

@@ -19,10 +19,7 @@ doctest = false
 
 [dependencies]
 vm-core = { package = "miden-core", path = "../core", version = "0.11", default-features = false }
-# processor = { package = "miden-processor", path = "../processor", version = "0.11", default-features = false }
-assembly = { package = "miden-assembly", path = "../assembly", version = "0.11", default-features = false, features = [
-  "serde",
-] }
+assembly = { package = "miden-assembly", path = "../assembly", version = "0.11", default-features = false }
 serde = { version = "1.0.208", features = ["alloc", "rc", "serde_derive"] }
 serde_bytes = "0.11.15"
 serde_repr = "0.1.19"

package/Cargo.toml

@@ -29,7 +29,6 @@ tracing = { version = "0.1", default-features = false, features = ["attributes"]
 vm-core = { package = "miden-core", path = "../core", version = "0.11", default-features = false }
 winter-prover = { package = "winter-prover", version = "0.11", default-features = false }
 thiserror = { workspace = true }
-package = { package = "miden-package", path = "../package", version = "0.11", default-features = false }
 
 [dev-dependencies]
 assembly = { package = "miden-assembly", path = "../assembly", version = "0.11", default-features = false }