forked from VirtueSecurity/aws-extender
-
Notifications
You must be signed in to change notification settings - Fork 0
/
aws_extender.py
1086 lines (979 loc) · 45.1 KB
/
aws_extender.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
# -*- coding: utf-8 -*-
# Version 1.0
from __future__ import absolute_import, print_function
import re
import time
try:
import urllib2 as urllib_req
from urllib2 import HTTPError, URLError, unquote
except ImportError:
import urllib.request as urllib_req
from urllib.error import HTTPError, URLError
from urllib.parse import unquote
import os.path
import xml.etree.cElementTree as CET
from xml.dom.minidom import parse
from array import array
from datetime import datetime
try:
import boto3
from botocore.exceptions import ClientError
from botocore.handlers import disable_signing
from botocore.compat import XMLParseError
from botocore.parsers import ResponseParserError
from boto.s3.connection import S3Connection
from boto.exception import S3ResponseError
RUN_TESTS = True
except ImportError:
RUN_TESTS = False
from burp import IBurpExtender
from burp import IScanIssue
from burp import IScannerCheck
from burp import ITab
from javax.swing import JTextField
from javax.swing import JLabel
from javax.swing import JFrame
from javax.swing import JPanel
from javax.swing import JButton
from javax.swing import JCheckBox
from javax.swing.border import EmptyBorder
from java.awt import BorderLayout
from java.awt import GridLayout
from org.xml.sax import SAXException
IDENTIFIED_VALUES = set()
class BurpExtender(IBurpExtender, IScannerCheck, ITab):
def __init__(self):
self.ext_name = 'AWS Extender'
self.callbacks = None
self.gui_elements = None
self.aws_access_key_inpt = None
self.aws_secret_key_inpt = None
self.aws_session_token_inpt = None
self.gs_access_key_inpt = None
self.gs_secret_key_inpt = None
self.wordlist_path_inpt = None
self.checkbox_inpt = None
self.aws_access_key = ''
self.aws_secret_key = ''
self.aws_session_token = ''
self.gs_access_key = ''
self.gs_secret_key = ''
self.wordlist_path = ''
def registerExtenderCallbacks(self, callbacks):
"""Register extender callbacks."""
self.callbacks = callbacks
# Set the name of the extension
self.callbacks.setExtensionName(self.ext_name)
# Register the extension as a scanner check
self.callbacks.registerScannerCheck(self)
# Build GUI elements
self.gui_elements = self.build_gui()
callbacks.customizeUiComponent(self.gui_elements)
callbacks.addSuiteTab(self)
self.check_loading_issues()
self.reload_config()
def show_errors(self, label):
"""Display error messages."""
top_label = JLabel(label, JLabel.CENTER)
frame = JFrame(self.ext_name)
frame.setSize(550, 300)
frame.setLayout(GridLayout(1, 1))
frame.add(top_label)
frame.setLocationRelativeTo(None)
frame.setVisible(True)
def check_loading_issues(self):
"""Check for any loading issues."""
missing_libs = []
tips = []
label = """<html>
<body style='margin: 10px'>
<b>The following dependencies could not be loaded successfully:</b><br>
<ul><li>%s</li></ul><br>
<b>Tips:</b><br>
<ul><li>%s</li><br></ul>
<b>For detailed information on how to load the plugin, see:</b><br>
<ul>
<li>
<a href='#'>https://github.com/VirtueSecurity/aws-extender#getting-started</a>
</li>
</ul>
</body>
</html>"""
if not RUN_TESTS:
missing_libs.append('boto/boto3')
tips.append('Make sure that the boto/boto3 library is installed properly, and\
the right path is specified in the "Folder for loading modules" setting.')
try:
CET.fromstring('<test></test>')
except SAXException:
# Try to workaround "http://bugs.jython.org/issue1127"
try:
def xml_parser(**_):
class Parser(object):
def feed(*_):
raise XMLParseError
def close(*_):
return None
return Parser()
CET.XMLParser = xml_parser
except TypeError:
missing_libs.append('SAXParser')
tips.append("""Run Burp Suite using the following command:
<br><code style='background: #f7f7f9; color: red'>$ java -classpath
xercesImpl.jar;burpsuite_pro.jar burp.StartBurp</code>""")
if not missing_libs:
return
label %= ('</li><li>'.join(missing_libs), '</li><li>'.join(tips))
self.show_errors(label)
def build_gui(self):
"""Construct GUI elements."""
panel = JPanel(BorderLayout(3, 3))
panel.setBorder(EmptyBorder(160, 160, 160, 160))
self.aws_access_key_inpt = JTextField(10)
self.aws_secret_key_inpt = JTextField(10)
self.aws_session_token_inpt = JTextField(10)
self.gs_access_key_inpt = JTextField(10)
self.gs_secret_key_inpt = JTextField(10)
self.wordlist_path_inpt = JTextField(10)
self.checkbox_inpt = JCheckBox('Enabled')
save_btn = JButton('Save', actionPerformed=self.save_config)
labels = JPanel(GridLayout(0, 1))
inputs = JPanel(GridLayout(0, 1))
panel.add(labels, BorderLayout.WEST)
panel.add(inputs, BorderLayout.CENTER)
top_label = JLabel('<html><b>Settings</b><br><br></html>')
top_label.setHorizontalAlignment(JLabel.CENTER)
panel.add(top_label, BorderLayout.NORTH)
labels.add(JLabel('AWS Access Key:'))
inputs.add(self.aws_access_key_inpt)
labels.add(JLabel('AWS Secret Key:'))
inputs.add(self.aws_secret_key_inpt)
labels.add(JLabel('AWS Session Key (optional):'))
inputs.add(self.aws_session_token_inpt)
labels.add(JLabel('GS Access Key:'))
inputs.add(self.gs_access_key_inpt)
labels.add(JLabel('GS Secret Key:'))
inputs.add(self.gs_secret_key_inpt)
labels.add(JLabel('Wordlist Filepath (optional):'))
inputs.add(self.wordlist_path_inpt)
labels.add(JLabel('Passive Mode:'))
inputs.add(self.checkbox_inpt)
panel.add(save_btn, BorderLayout.SOUTH)
return panel
def save_config(self, _):
"""Save settings."""
error_message = ''
wordlist_path = self.wordlist_path_inpt.getText()
save_setting = self.callbacks.saveExtensionSetting
save_setting('aws_access_key', self.aws_access_key_inpt.getText())
save_setting('aws_secret_key', self.aws_secret_key_inpt.getText())
save_setting('aws_session_token', self.aws_session_token_inpt.getText())
save_setting('gs_access_key', self.gs_access_key_inpt.getText())
save_setting('gs_secret_key', self.gs_secret_key_inpt.getText())
save_setting('wordlist_path', wordlist_path)
if self.checkbox_inpt.isSelected():
save_setting('passive_mode', 'True')
else:
save_setting('passive_mode', '')
if wordlist_path and not os.path.isfile(wordlist_path):
error_message = 'Error: Invalid filepath for the "Wordlist Filepath" setting.'
self.show_errors(error_message)
self.reload_config()
def reload_config(self):
"""Reload saved settings."""
global RUN_TESTS
load_setting = self.callbacks.loadExtensionSetting
aws_access_key_val = load_setting('aws_access_key') or ''
aws_secret_key_val = load_setting('aws_secret_key') or ''
aws_session_token_val = load_setting('aws_session_token') or ''
gs_access_key_val = load_setting('gs_access_key') or ''
gs_secret_key_val = load_setting('gs_secret_key') or ''
wordlist_path_val = load_setting('wordlist_path') or ''
checkbox_inpt_val = load_setting('passive_mode')
checkbox_inpt_val = bool(str(checkbox_inpt_val)) if checkbox_inpt_val else False
if checkbox_inpt_val:
RUN_TESTS = False
else:
RUN_TESTS = True
self.aws_access_key = aws_access_key_val
self.aws_secret_key = aws_secret_key_val
self.aws_session_token = aws_session_token_val
self.gs_access_key = gs_access_key_val
self.gs_secret_key = gs_secret_key_val
self.wordlist_path = wordlist_path_val
self.aws_access_key_inpt.setText(aws_access_key_val)
self.aws_secret_key_inpt.setText(aws_secret_key_val)
self.aws_session_token_inpt.setText(aws_session_token_val)
self.gs_access_key_inpt.setText(gs_access_key_val)
self.gs_secret_key_inpt.setText(gs_secret_key_val)
self.wordlist_path_inpt.setText(wordlist_path_val)
self.checkbox_inpt.setSelected(checkbox_inpt_val)
def getTabCaption(self):
"""Return tab caption."""
return self.ext_name
def getUiComponent(self):
"""Return GUI elements."""
return self.gui_elements
def doPassiveScan(self, request_response):
"""Perform a passive scan."""
scan_issues = []
opts = {'aws_access_key': self.aws_access_key,
'aws_secret_key': self.aws_secret_key,
'aws_session_token': self.aws_session_token,
'gs_access_key': self.gs_access_key,
'gs_secret_key': self.gs_secret_key,
'wordlist_path': self.wordlist_path}
bucket_scan = BucketScan(request_response, self.callbacks, opts)
bucket_issues = bucket_scan.check_buckets()
cognito_scan = CognitoScan(request_response, self.callbacks)
cognito_issues = cognito_scan.identify_identity_pools()
scan_issues = bucket_issues + cognito_issues
if len(scan_issues) > 0:
return scan_issues
return None
@staticmethod
def doActiveScan(*_):
pass
@staticmethod
def consolidateDuplicateIssues(existing_issue, new_issue):
"""Eliminate duplicate issues."""
if existing_issue.getIssueDetail() == new_issue.getIssueDetail():
return -1
else:
return 0
class BucketScan(object):
"""Scan cloud storage buckets."""
def __init__(self, request_response, callbacks, opts):
self.request_response = request_response
self.callbacks = callbacks
self.helpers = self.callbacks.getHelpers()
bytesToString = self.helpers.bytesToString
self.request = self.request_response.getRequest()
self.request_str = bytesToString(self.request)
self.request_len = len(self.request_str)
self.request_str = self.request_str.encode('utf-8', 'replace')
self.response = self.request_response.getResponse()
self.response_str = bytesToString(self.response)
self.response_len = len(self.response_str)
self.response_str = self.response_str.encode('utf-8', 'replace')
self.offset = array('i', [0, 0])
self.current_url = self.helpers.analyzeRequest(self.request_response).getUrl()
self.scan_issues = []
self.aws_access_key = opts['aws_access_key']
self.aws_secret_key = opts['aws_secret_key']
self.aws_session_token = opts['aws_session_token']
self.gs_access_key = opts['gs_access_key']
self.gs_secret_key = opts['gs_secret_key']
self.wordlist_path = opts['wordlist_path']
try:
self.boto3_client = boto3.client('s3',
aws_access_key_id=self.aws_access_key,
aws_secret_access_key=self.aws_secret_key,
aws_session_token=self.aws_session_token)
self.boto_s3_con = S3Connection(
aws_access_key_id=self.aws_access_key,
aws_secret_access_key=self.aws_secret_key,
host='s3.amazonaws.com'
)
self.boto_gs_con = S3Connection(
aws_access_key_id=self.gs_access_key,
aws_secret_access_key=self.gs_secret_key,
host='storage.googleapis.com'
)
if not (self.aws_access_key and self.aws_secret_key):
self.boto3_client.meta.events.register('choose-signer.s3.*', disable_signing)
self.boto_s3_con = S3Connection(anon=True)
if not (self.gs_access_key and self.gs_secret_key):
self.boto_gs_con = S3Connection(anon=True, host='storage.googleapis.com')
except NameError:
pass
def bucket_exists(self, bucket_name, bucket_type):
"""Confirm if an S3 bucket exists."""
if bucket_type == 'S3':
try:
self.boto3_client.head_bucket(Bucket=bucket_name)
except ClientError as error:
error_code = int(error.response['Error']['Code'])
if error_code == 404:
return False
elif bucket_type == 'GS':
try:
self.boto_gs_con.head_bucket(bucket_name)
except S3ResponseError as error:
if error.error_code == 'NoSuchBucket':
return False
elif bucket_type == 'Azure':
try:
bucket_url = 'https://' + bucket_name + '?comp=list&maxresults=10'
urllib_req.urlopen(urllib_req.Request(bucket_url), timeout=20)
except (HTTPError, URLError):
if not self.wordlist_path:
return False
return True
def test_bucket(self, bucket_name, bucket_type):
"""Test for buckets misconfiguration issues."""
grants = []
issues = []
keys = []
def enumerate_keys(bucket, bucket_name, bucket_type):
"""Enumerate bucket keys."""
try:
with open(self.wordlist_path) as wordlist:
wordlist_keys = wordlist.read()
key_list = wordlist_keys.split('\n')
except IOError:
return
if bucket_type != 'Azure':
for key in key_list:
try:
key = bucket.get_key(key).key
self.test_object(bucket_name, bucket_type, key, False)
except (S3ResponseError, AttributeError):
continue
else:
bucket = bucket if bucket.endswith('/') else bucket + '/'
for key in key_list:
try:
request = urllib_req.Request(bucket + key)
urllib_req.urlopen(request, timeout=20)
keys.append(key)
except (HTTPError, URLError):
continue
if bucket_type == 'S3':
bucket = self.boto_s3_con.get_bucket(bucket_name, validate=False)
try:
bucket_acl = bucket.get_acl().acl
for grant in bucket_acl.grants:
grants.append((grant.display_name or grant.uri or grant.id) + '->' +
grant.permission)
issues.append('s3:GetBucketAcl<ul><li>%s</li></ul>' % '</li><li>'.join(grants))
except S3ResponseError as error:
print('Error Code (get_bucket_acl): ' + str(error.error_code))
try:
self.boto3_client.get_bucket_cors(Bucket=bucket_name)
issues.append('s3:GetBucketCORS')
except ClientError as error:
error_code = error.response['Error']['Code']
print('Error Code (get_bucket_cors): ' + str(error_code))
except ResponseParserError:
issues.append('s3:GetBucketCORS')
try:
self.boto3_client.get_bucket_lifecycle(Bucket=bucket_name)
issues.append('s3:GetLifecycleConfiguration')
except ClientError as error:
error_code = error.response['Error']['Code']
print('Error Code (get_bucket_lifecycle): ' + str(error_code))
except ResponseParserError:
issues.append('s3:GetLifecycleConfiguration')
try:
self.boto3_client.get_bucket_notification(Bucket=bucket_name)
issues.append('s3:GetBucketNotification')
except ClientError as error:
error_code = error.response['Error']['Code']
print('Error Code (get_bucket_notification): ' + str(error_code))
except ResponseParserError:
issues.append('s3:GetBucketNotification')
try:
self.boto3_client.get_bucket_policy(Bucket=bucket_name)
issues.append('s3:GetBucketPolicy')
except ClientError as error:
error_code = error.response['Error']['Code']
print('Error Code (get_bucket_policy): ' + str(error_code))
except ResponseParserError:
issues.append('s3:GetBucketPolicy')
try:
self.boto3_client.get_bucket_tagging(Bucket=bucket_name)
issues.append('s3:GetBucketTagging')
except ClientError as error:
error_code = error.response['Error']['Code']
print('Error Code (get_bucket_tagging): ' + str(error_code))
except ResponseParserError:
issues.append('s3:GetBucketTagging')
try:
self.boto3_client.get_bucket_website(Bucket=bucket_name)
issues.append('s3:GetBucketWebsite')
except ClientError as error:
error_code = error.response['Error']['Code']
print('Error Code (get_bucket_website): ' + str(error_code))
except ResponseParserError:
issues.append('s3:GetBucketWebsite')
try:
self.boto3_client.list_multipart_uploads(Bucket=bucket_name)
issues.append('s3:ListMultipartUploadParts')
except ClientError as error:
error_code = error.response['Error']['Code']
print('Error Code (list_multipart_uploads): ' + str(error_code))
except ResponseParserError:
issues.append('s3:ListMultipartUploadParts')
try:
i = 0
for k in bucket.list():
i = i + 1
keys.append(k.key)
if i == 10:
break
issues.append('s3:ListBucket<ul><li>%s</li></ul>' % '</li><li>'.join(keys))
except S3ResponseError as error:
print('Error Code (list): ' + str(error.error_code))
if self.wordlist_path:
enumerate_keys(bucket, bucket_name, 'S3')
try:
self.boto3_client.put_bucket_cors(
Bucket=bucket_name,
CORSConfiguration={
'CORSRules': [
{
'AllowedMethods': [
'GET'
],
'AllowedOrigins': [
'*'
]
}
]
}
)
issues.append('s3:PutBucketCORS')
except ClientError as error:
error_code = error.response['Error']['Code']
print('Error Code (put_bucket_cors): ' + str(error_code))
except ResponseParserError:
issues.append('s3:PutBucketCORS')
try:
self.boto3_client.put_bucket_lifecycle_configuration(
Bucket=bucket_name,
LifecycleConfiguration={
'Rules': [
{
'Status': 'Disabled',
'Prefix': 'test'
}
]
}
)
issues.append('s3:PutLifecycleConfiguration')
except ClientError as error:
error_code = error.response['Error']['Code']
print('Error Code (put_bucket_lifecycle_configuration): ' + str(error_code))
except ResponseParserError:
issues.append('s3:PutLifecycleConfiguration')
try:
self.boto3_client.put_bucket_logging(
Bucket=bucket_name,
BucketLoggingStatus={}
)
issues.append('s3:PutBucketLogging')
except ClientError as error:
error_code = error.response['Error']['Code']
print('Error Code (put_bucket_logging): ' + str(error_code))
except ResponseParserError:
issues.append('s3:PutBucketLogging')
try:
self.boto3_client.put_bucket_notification(
Bucket=bucket_name,
NotificationConfiguration={
'TopicConfiguration': {
'Events': ['s3:ReducedRedundancyLostObject'],
'Topic': 'arn:aws:sns:us-west-2:444455556666:sns-topic-one'
}
}
)
issues.append('s3:PutBucketNotification')
except ClientError as error:
error_code = error.response['Error']['Code']
print('Error Code (put_bucket_notification): ' + str(error_code))
except ResponseParserError:
issues.append('s3:PutBucketNotification')
try:
self.boto3_client.put_bucket_tagging(
Bucket=bucket_name,
Tagging={
'TagSet': [
{
'Key': 'test',
'Value': 'test'
}
]
}
)
issues.append('s3:PutBucketTagging')
except ClientError as error:
error_code = error.response['Error']['Code']
print('Error Code (put_bucket_tagging): ' + str(error_code))
except ResponseParserError:
issues.append('s3:PutBucketTagging')
try:
self.boto3_client.put_bucket_website(
Bucket=bucket_name,
WebsiteConfiguration={
'ErrorDocument': {
'Key': 'test'
},
'IndexDocument': {
'Suffix': 'test'
}
}
)
issues.append('s3:PutBucketWebsite')
except ClientError as error:
error_code = error.response['Error']['Code']
print('Error Code (put_bucket_website): ' + str(error_code))
except ResponseParserError:
issues.append('s3:PutBucketWebsite')
try:
self.boto3_client.put_object(
Body=b'test',
Bucket=bucket_name,
Key='test.txt'
)
issues.append('s3:PutObject<ul><li>test.txt</li></ul>')
except ClientError as error:
error_code = error.response['Error']['Code']
print('Error Code (put_object): ' + str(error_code))
except ResponseParserError:
issues.append('s3:PutObject')
if '.' in bucket_name:
try:
self.boto3_client.put_bucket_acl(
GrantFullControl='uri="http://acs.amazonaws.com/groups/global/AllUsers"',
Bucket=bucket_name
)
issues.append('s3:PutBucketAcl')
except ClientError as error:
error_code = error.response['Error']['Code']
print('Error Code (put_bucket_acl): ' + str(error_code))
except ResponseParserError:
issues.append('s3:PutBucketAcl')
else:
try:
bucket.add_email_grant('FULL_CONTROL', 0)
issues.append('s3:PutBucketAcl')
except S3ResponseError as error:
if error.error_code == 'UnresolvableGrantByEmailAddress':
issues.append('s3:PutBucketAcl')
try:
self.boto3_client.put_bucket_policy(
Bucket=bucket_name,
Policy='''
{
"Version":"2012-10-17",
"Statement": [
{
"Effect":"Allow",
"Principal": "*",
"Action":["s3:GetBucketPolicy"],
"Resource":["arn:aws:s3:::%s/*"]
}
]
} ''' % bucket_name
)
issues.append('s3:PutBucketPolicy')
except ClientError as error:
error_code = error.response['Error']['Code']
print('Error Code (put_bucket_policy): ' + str(error_code))
except ResponseParserError:
issues.append('s3:PutBucketPolicy')
elif bucket_type == 'GS':
bucket = self.boto_gs_con.get_bucket(bucket_name, validate=False)
try:
i = 0
for k in bucket.list():
i = i + 1
keys.append(k.key)
if i == 10:
break
issues.append('READ<ul><li>%s</li></ul>' % '</li><li>'.join(keys))
except S3ResponseError as error:
print('Error Code (list): ' + str(error.error_code))
if self.wordlist_path:
enumerate_keys(bucket, bucket_name, 'GS')
try:
key = bucket.new_key('test.txt')
key.set_contents_from_string('')
issues.append('WRITE<ul><li>test.txt</li></ul>')
except S3ResponseError as error:
print('Error Code (set_contents_from_string): ' + str(error.error_code))
try:
bucket.add_email_grant('FULL_CONTROL', 0)
issues.append('FULL_CONTROL')
except S3ResponseError as error:
if error.error_code == 'UnresolvableGrantByEmailAddress':
issues.append('FULL_CONTROL')
else:
print('Error Code (add_email_grant): ' + str(error.error_code))
except AttributeError as error:
if error.message.startswith("'Policy'"):
issues.append('FULL_CONTROL')
else:
raise
elif bucket_type == 'Azure':
bucket_url = 'https://' + bucket_name
try:
request = urllib_req.Request(bucket_url + '?comp=list&maxresults=10')
response = urllib_req.urlopen(request, timeout=20)
blobs = parse(response).documentElement.getElementsByTagName('Name')
for blob in blobs:
keys.append(blob.firstChild.nodeValue.encode('utf-8'))
issues.append('Full public read access<ul><li>%s</li></ul>' %
'</li><li>'.join(keys))
except (AttributeError, HTTPError, URLError):
if self.wordlist_path:
enumerate_keys(bucket_url, bucket_name, 'Azure')
if keys:
issues.append('Public read access for blobs only<ul><li>%s</li></ul>' %
'</li><li>'.join(keys))
if not issues:
return False
if ('s3:PutBucketAcl' in issues or 'FULL_CONTROL' in issues) or len(issues) > 4:
issue_level = 'High'
elif len(issues) > 2 or ('READ' in issues and
'WRITE<ul><li>test.txt</li></ul>' in issues):
issue_level = 'Medium'
else:
issue_level = 'Low'
issue_name = '%s Bucket Misconfiguration' % bucket_type
issue_detail = '''The "%s" %s bucket grants the following permissions:<br>
<li>%s</li><br><br>''' % (bucket_name, bucket_type,
'</li><li>'.join(issues))
return {'issue_name': issue_name, 'issue_detail': issue_detail,
'issue_level': issue_level}
def check_timestamp(self, bucket_url, bucket_type, timestamp):
"""Check timestamps of signed URLs."""
timestamp_raw = timestamp
offsets = []
mark_request = False
start = 0
try:
if bucket_type != 'Azure':
now = int(time.time())
diff = (int(timestamp) - now) / 3600
else:
timestamp = unquote(timestamp)
timestamp = datetime.strptime(timestamp, '%Y-%m-%dT%H:%M:%S%fZ')
diff = int((timestamp - datetime.now()).total_seconds()) / 3600
except ValueError:
return
if diff > 24:
start = self.helpers.indexOf(self.response,
timestamp_raw, True, 0, self.response_len)
if start < 0:
start = self.helpers.indexOf(self.request,
timestamp_raw, True, 0, self.request_len)
mark_request = True
self.offset[0] = start
self.offset[1] = start + len(timestamp_raw)
offsets.append(self.offset)
if mark_request:
markers = [self.callbacks.applyMarkers(self.request_response, offsets, None)]
else:
markers = [self.callbacks.applyMarkers(self.request_response, None, offsets)]
issue_name = '%s Signed URL Excessive Expiration Time' % bucket_type
issue_level = 'Information'
issue_detail = '''The following %s signed URL was found to be valid for more than
24 hours (expires in %sh):<br><li>%s</li>''' % (bucket_type, diff, bucket_url)
self.scan_issues.append(
ScanIssue(self.request_response.getHttpService(),
self.current_url, markers, issue_name, issue_level, issue_detail)
)
def test_object(self, bucket_name, bucket_type, key, mark=True):
"""Test individual bucket objects."""
issues = []
grants = []
markers = []
offsets = []
issue_name = ''
permission = ''
mark_request = False
norm_key = key.replace('\\', '')
if bucket_type == 'S3':
bucket = self.boto_s3_con.get_bucket(bucket_name, validate=False)
else:
bucket = self.boto_gs_con.get_bucket(bucket_name, validate=False)
try:
key_obj = bucket.get_key(norm_key)
except S3ResponseError:
return
if not key_obj:
return
issues.append('READ')
try:
key_acl = key_obj.get_acl().acl
for grant in key_acl.grants:
grants.append((grant.display_name or grant.uri or grant.id) + '->' +
grant.permission)
permission = 's3:GetObjectAcl' if bucket_type == 'S3' else 'getIamPolicy'
issues.append('%s<ul><li>%s</li></ul>' % (permission, '</li><li>'.join(grants)))
except S3ResponseError:
pass
if '.' in bucket_name and bucket_type == 'S3':
try:
self.boto3_client.put_object_acl(
GrantFullControl='uri="http://acs.amazonaws.com/groups/global/AllUsers"',
Bucket=bucket_name,
Key=norm_key
)
issues.append('s3:PutObjectAcl')
except ClientError as error:
error_code = error.response['Error']['Code']
print('Error Code (put_object_acl): ' + str(error_code))
except ResponseParserError:
issues.append('s3:PutObjectAcl')
else:
try:
key_obj.add_email_grant('FULL_CONTROL', 0)
permission = 's3:PutObjectAcl' if bucket_type == 'S3' else 'FULL_CONTROL'
issues.append(permission)
except S3ResponseError as error:
if error.error_code == 'UnresolvableGrantByEmailAddress':
permission = 's3:PutObjectAcl' if bucket_type == 'S3' else 'FULL_CONTROL'
issues.append(permission)
if not issues:
return
if 'READ' in issues and len(issues) < 2:
issue_level = 'Information'
issue_name = '%s Object Publicly Accessible' % bucket_type
elif 's3:PutObjectAcl' in issues or 'FULL_CONTROL' in issues:
issue_level = 'High'
else:
issue_level = 'Low'
start = self.helpers.indexOf(self.response,
key, True, 0, self.response_len)
if start < 0 and mark:
start = self.helpers.indexOf(self.request,
key, True, 0, self.request_len)
mark_request = True
self.offset[0] = start
self.offset[1] = start + len(key)
offsets.append(self.offset)
if mark_request:
markers = [self.callbacks.applyMarkers(self.request_response, offsets, None)]
elif mark:
markers = [self.callbacks.applyMarkers(self.request_response, None, offsets)]
if not issue_name:
issue_name = '%s Object Misconfiguration' % bucket_type
issue_detail = '''The following ACL grants were found set on the "%s" object of
the "%s" %s bucket:<br><li>%s</li>''' % (norm_key, bucket_name, bucket_type,
'</li><li>'.join(issues))
self.scan_issues.append(
ScanIssue(self.request_response.getHttpService(),
self.current_url, markers, issue_name, issue_level, issue_detail)
)
def check_buckets(self):
"""Check storage buckets."""
current_url_str = str(unicode(self.current_url, 'utf-8'))
host, path = re.findall(r'\w+://([\w.-]+)(?::\d+)?(?:/([^\s?#]*))?', current_url_str)[0]
# Matches S3 bucket names
s3_buckets_regex = re.compile(
r'((?:\w+://)?(?:([\w.-]+)\.s3[\w.-]*\.amazonaws\.com|s3(?:[\w.-]*\.amazonaws\.com(?:(?::\d+)?\\?/)*|://)([\w.-]+))(?:(?::\d+)?\\?/([^\s?#]*))?(?:.*?\?.*Expires=(\d+))?)',
re.I)
s3_bucket_matches = re.findall(s3_buckets_regex, current_url_str)
s3_bucket_matches += re.findall(s3_buckets_regex, self.request_str)
s3_bucket_matches += re.findall(s3_buckets_regex, self.response_str)
# Matches GS bucket names
gs_buckets_regex = re.compile(
r'((?:\w+://)?(?:([\w.-]+)\.storage[\w-]*\.googleapis\.com|(?:(?:console\.cloud\.google\.com/storage/browser/|storage[\w-]*\.googleapis\.com)(?:(?::\d+)?\\?/)*|gs://)([\w.-]+))(?:(?::\d+)?\\?/([^\s?#]*))?(?:.*\?.*Expires=(\d+))?)',
re.I)
gs_bucket_matches = re.findall(gs_buckets_regex, current_url_str)
gs_bucket_matches += re.findall(gs_buckets_regex, self.request_str)
gs_bucket_matches += re.findall(gs_buckets_regex, self.response_str)
# Matches Azure container URIs
az_buckets_regex = re.compile(
r'(([\w.-]+\.blob\.core\.windows\.net(?::\d+)?\\?/[\w.-]+)(?:.*?\?.*se=([\w%-]+))?)',
re.I)
az_bucket_matches = re.findall(az_buckets_regex, current_url_str)
az_bucket_matches += re.findall(az_buckets_regex, self.request_str)
az_bucket_matches += re.findall(az_buckets_regex, self.response_str)
if RUN_TESTS:
s3_bucket_matches.append(('', host, '', path))
gs_bucket_matches.append(('', host, '', path))
def assess_buckets(bucket_matches, bucket_type):
"""Assess identified buckets."""
mark_request = False
for i in xrange(0, len(bucket_matches)):
issues = []
offsets = []
bucket_match = bucket_matches[i]
bucket_url = bucket_match[0]
bucket_name = bucket_match[1] or bucket_match[2]
timestamp = bucket_match[-1]
bucket_tuple = (bucket_name, host)
timestamp_tuple = (timestamp, bucket_url, host)
if RUN_TESTS and not self.bucket_exists(bucket_name, bucket_type):
continue
try:
key = bucket_match[3]
key_tuple = (key, bucket_name, host)
if key and key_tuple not in IDENTIFIED_VALUES and RUN_TESTS:
self.test_object(bucket_name, bucket_type, key)
IDENTIFIED_VALUES.add(key_tuple)
except IndexError:
pass
if timestamp and timestamp_tuple not in IDENTIFIED_VALUES:
self.check_timestamp(bucket_url, bucket_type, timestamp)
IDENTIFIED_VALUES.add(timestamp_tuple)
if bucket_tuple in IDENTIFIED_VALUES:
continue
IDENTIFIED_VALUES.add(bucket_tuple)
start = self.helpers.indexOf(self.response,
bucket_name, True, 0, self.response_len)
if start < 0:
start = self.helpers.indexOf(self.request,
bucket_name, True, 0, self.request_len)
mark_request = True
self.offset[0] = start
self.offset[1] = start + len(bucket_name)
offsets.append(self.offset)
if mark_request:
markers = [self.callbacks.applyMarkers(self.request_response, offsets, None)]
else:
markers = [self.callbacks.applyMarkers(self.request_response, None, offsets)]
if RUN_TESTS:
issues = self.test_bucket(bucket_name, bucket_type)
if issues:
self.scan_issues.append(
ScanIssue(self.request_response.getHttpService(),
self.helpers.analyzeRequest(self.request_response).getUrl(),
markers, issues['issue_name'], issues['issue_level'], issues['issue_detail']
)
)
if not issues:
issue_name = '%s Bucket Detected' % bucket_type
issue_level = 'Information'
issue_detail = '''The following %s bucket has been identified:<br>
<li>%s</li>''' % (bucket_type, bucket_name)
self.scan_issues.append(
ScanIssue(self.request_response.getHttpService(),
self.current_url, markers, issue_name, issue_level, issue_detail)
)
if s3_bucket_matches:
assess_buckets(s3_bucket_matches, 'S3')
if gs_bucket_matches:
assess_buckets(gs_bucket_matches, 'GS')
if az_bucket_matches:
assess_buckets(az_bucket_matches, 'Azure')
return self.scan_issues
class CognitoScan(object):
"""Identify and test Cognito identity pools."""
def __init__(self, request_response, callbacks):
self.request_response = request_response
self.callbacks = callbacks
self.helpers = self.callbacks.getHelpers()
self.current_url = self.helpers.analyzeRequest(self.request_response).getUrl()
self.scan_issues = []
def obtain_unauth_token(self, identity_pool_id, identity_id, region, markers):
"""Obtain an unauthenticated identity token."""
client = boto3.client('cognito-identity', region_name=region)
try:
token = client.get_open_id_token(IdentityId=identity_id)['Token']
except (ClientError, KeyError):
return
issue_name = 'Cognito Unauthenticated Identities Enabled'
issue_level = 'Information'
issue_detail = '''The following identity pool allows unauthenticated identities:
<br><ul><li>%s</li></ul><br>The following identity ID has been obtained:
<ul><li>%s</li></ul><br>The following token has been obtained:
<ul><li>%s</li></ul>''' % (identity_pool_id, identity_id, token)
self.scan_issues.append(
ScanIssue(self.request_response.getHttpService(),
self.current_url, markers, issue_name, issue_level, issue_detail)
)
def identify_identity_pools(self):
"""Identify Cognito identity pools."""
bytesToString = self.helpers.bytesToString
request = self.request_response.getRequest()
request_str = bytesToString(request)
request_len = len(request_str)
request_str = request_str.encode('utf-8', 'replace')
response = self.request_response.getResponse()
response_str = bytesToString(response)
response_len = len(response_str)
response_str = response_str.encode('utf-8', 'replace')
identity_pool_regex = re.compile(
r'((us-[\w-]+):[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12})',
re.I)
identity_pools = re.findall(identity_pool_regex, request_str)
identity_pools += re.findall(identity_pool_regex, response_str)
def verify_identity_pools(identity_pool_ids):
"""Verify identity pools."""
offset = array('i', [0, 0])
host = re.search(r'\w+://([\w.-]+)', str(self.current_url)).group(1)
for i in xrange(0, len(identity_pool_ids)):
offsets = []
identity_id = ''
mark_request = False
identity_pool_id = identity_pool_ids[i]
region = identity_pool_id[1]
identity_pool_id = identity_pool_id[0]
identity_pool_tuple = (identity_pool_id, host)
if identity_pool_id and identity_pool_tuple in IDENTIFIED_VALUES: