Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augmentation Filter #222

Open
Leomelati opened this issue Nov 20, 2023 · 11 comments
Open

Augmentation Filter #222

Leomelati opened this issue Nov 20, 2023 · 11 comments

Comments

@Leomelati
Copy link

As an Augmentation Evoker, it would be nice if we had a filter to hide groups that already have one.

@0xbs
Copy link
Owner

0xbs commented Nov 20, 2023

Good suggestion, but hard to implement, because the spec is only availabe as a localized string. This means I would have to map for example "Verstärkung" to "Augmentation" for every language there is in the game. To make it a bit more complicated, German "Verstärkung" can also mean "Enhancement" in case of a Shaman.

So I'm afraid you will have to keep looking at the tooltip to get the exact spec for now.

@0xbs 0xbs closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2023
@teelolws
Copy link

teelolws commented Jan 30, 2024

Could you not just use select(2, GetSpecializationInfoByID(1473))? Both that, and the premade finder, should show "Augmentation" in the player's local language.

@0xbs
Copy link
Owner

0xbs commented Feb 2, 2024

Might be possible, I will look into it

@0xbs 0xbs reopened this Feb 2, 2024
0xbs added a commit that referenced this issue Feb 2, 2024
@0xbs
Copy link
Owner

0xbs commented Feb 2, 2024

Version 5.3.0-beta now supports specializations. Use augs == 0 to remove all groups with augmentation evokers. See Keywords page for more details.

@teelolws
Copy link

teelolws commented Feb 2, 2024

I suggest an alternative like spec["Augumentation"] where in another locale the player can write spec["whatever"] in their local language. Like what you did with the boss filter.

@Leomelati
Copy link
Author

@0xbs Thank you for the implementation!

@0xbs
Copy link
Owner

0xbs commented Feb 2, 2024

Would be easy to do, but there are collisions without the class, for example:

  • English "Restoration" for resto druids and resto shamans
  • German "Verstärkung" for enhancement shamans and augmentation evokers

This would make the filter kind of useless.

@teelolws
Copy link

teelolws commented Feb 2, 2024

Truuue... maybe spec[evokers, "Augumentation"] and spec["Evoker", "Augumentation"]?

@0xbs
Copy link
Owner

0xbs commented Feb 2, 2024

We might have a misunderstanding. I did not only implement augs, but every combination there is in the game like augmentation_evokers, restoration_druids, arms_warriors, ...

See the full list of keywords.

They are English only like all other keywords.

augs is just a short additional alias for augmentations evokers.

@teelolws
Copy link

teelolws commented Feb 2, 2024

No I understand, just trying to help keep it friendlier for non-english speakers

@0xbs
Copy link
Owner

0xbs commented Feb 2, 2024

Okay, I will have a look if I can do something like you suggested with both a localized class and spec name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants