[FEATURE] Donner la possibilitée aux organisations sans imports de télécharger des attestations (PIX-15612)

 #10884

Author: pix-service-auto-merge

Diff for: api/db/seeds/data/common/organization-builder.js

@@ -33,7 +33,6 @@ async function _createScoOrganization(databaseBuilder) {
     features: [
       { id: FEATURE_COMPUTE_ORGANIZATION_LEARNER_CERTIFICABILITY_ID },
       { id: FEATURE_MULTIPLE_SENDING_ASSESSMENT_ID },
-      { id: FEATURE_ATTESTATIONS_MANAGEMENT_ID },
     ],
   });
 
@@ -46,7 +45,7 @@ async function _createScoOrganization(databaseBuilder) {
     externalId: 'SCO_NOT_MANAGING',
     adminIds: [USER_ID_ADMIN_ORGANIZATION],
     memberIds: [USER_ID_MEMBER_ORGANIZATION],
-    features: [{ id: FEATURE_MULTIPLE_SENDING_ASSESSMENT_ID }],
+    features: [{ id: FEATURE_MULTIPLE_SENDING_ASSESSMENT_ID }, { id: FEATURE_ATTESTATIONS_MANAGEMENT_ID }],
   });
 
   await organization.createOrganization({

Diff for: api/db/seeds/data/team-prescription/build-quests.js

@@ -6,6 +6,7 @@ import { temporaryStorage } from '../../../../src/shared/infrastructure/temporar
 import {
   AEFE_TAG,
   FEATURE_ATTESTATIONS_MANAGEMENT_ID,
+  SCO_ORGANIZATION_ID,
   USER_ID_ADMIN_ORGANIZATION,
   USER_ID_MEMBER_ORGANIZATION,
 } from '../common/constants.js';
@@ -399,4 +400,20 @@ export const buildQuests = async (databaseBuilder) => {
 
   // Insert job count in temporary storage for pending user
   await profileRewardTemporaryStorage.increment(pendingUser.id);
+
+  // Create learner with profile rewards for SCO organization without import
+  const { id: otherUserId } = databaseBuilder.factory.buildUser({ firstName: 'Alex', lastName: 'Tension' });
+  databaseBuilder.factory.buildOrganizationLearner({
+    organizationId: SCO_ORGANIZATION_ID,
+    userId: otherUserId,
+  });
+  const { id: otherUserProfileRewardId } = databaseBuilder.factory.buildProfileReward({
+    userId: otherUserId,
+    rewardType: REWARD_TYPES.ATTESTATION,
+    rewardId,
+  });
+  databaseBuilder.factory.buildOrganizationsProfileRewards({
+    organizationId: SCO_ORGANIZATION_ID,
+    profileRewardId: otherUserProfileRewardId,
+  });
 };

Diff for: api/src/prescription/organization-learner/infrastructure/repositories/organization-learner-repository.js

@@ -114,11 +114,15 @@ async function findPaginatedLearners({ organizationId, page, filter }) {
 }
 
 async function findOrganizationLearnersByDivisions({ organizationId, divisions }) {
+  let organizationLearners;
+
   const knexConnection = DomainTransaction.getConnection();
-  const organizationLearners = await knexConnection
-    .from('view-active-organization-learners')
-    .where({ organizationId })
-    .whereIn('division', divisions);
+  const queryBuilder = knexConnection.from('view-active-organization-learners').where({ organizationId });
+  if (divisions.length > 0) {
+    organizationLearners = await queryBuilder.whereIn('division', divisions);
+  } else {
+    organizationLearners = await queryBuilder;
+  }
   return organizationLearners.map((organizationLearner) => new OrganizationLearner(organizationLearner));
 }
 

Diff for: api/tests/prescription/organization-learner/integration/infrastructure/repositories/organization-learner-repository_test.js

@@ -724,5 +724,23 @@ describe('Integration | Infrastructure | Repository | Organization Learner', fun
         expect(result).to.be.empty;
       });
     });
+    context('when divisions is an empty array', function () {
+      it('should return all learners', async function () {
+        // given
+        databaseBuilder.factory.buildOrganizationLearner({ organizationId, division: '6eme A' });
+        databaseBuilder.factory.buildOrganizationLearner({ organizationId, division: '6eme B' });
+
+        await databaseBuilder.commit();
+
+        // when
+        const result = await organizationLearnerRepository.findOrganizationLearnersByDivisions({
+          organizationId,
+          divisions: [],
+        });
+
+        // then
+        expect(result).to.have.lengthOf(2);
+      });
+    });
   });
 });

Diff for: orga/app/components/attestations/sixth-grade.gjs

@@ -2,14 +2,17 @@ import PixButton from '@1024pix/pix-ui/components/pix-button';
 import PixMultiSelect from '@1024pix/pix-ui/components/pix-multi-select';
 import { on } from '@ember/modifier';
 import { action } from '@ember/object';
+import { service } from '@ember/service';
 import Component from '@glimmer/component';
 import { tracked } from '@glimmer/tracking';
 import { t } from 'ember-intl';
+import { eq } from 'ember-truth-helpers';
 
 import PageTitle from '../ui/page-title';
 
 export default class AttestationsSixthGrade extends Component {
   @tracked selectedDivisions = [];
+  @service currentUser;
 
   @action
   onSubmit(event) {
@@ -30,27 +33,37 @@ export default class AttestationsSixthGrade extends Component {
   <template>
     <PageTitle>
       <:title>{{t "pages.attestations.title"}}</:title>
-      <:subtitle>
+    </PageTitle>
+
+    {{#if (eq @divisions undefined)}}
+      <div>
         <p class="attestations-page__text">
-          {{t "pages.attestations.description"}}
+          {{t "pages.attestations.basic-description"}}
         </p>
-      </:subtitle>
-    </PageTitle>
+        <PixButton @triggerAction={{this.onSubmit}} @size="small">
+          {{t "pages.attestations.download-attestations-button"}}
+        </PixButton>
+      </div>
+    {{else}}
+      <p class="attestations-page__text">
+        {{t "pages.attestations.divisions-description"}}
+      </p>
 
-    <form class="attestations-page__action" {{on "submit" this.onSubmit}}>
-      <PixMultiSelect
-        @isSearchable={{true}}
-        @options={{@divisions}}
-        @values={{this.selectedDivisions}}
-        @onChange={{this.onSelectDivision}}
-        @placeholder={{t "common.filters.placeholder"}}
-      >
-        <:label>{{t "pages.attestations.select-label"}}</:label>
-        <:default as |option|>{{option.label}}</:default>
-      </PixMultiSelect>
-      <PixButton @type="submit" id="download_attestations" @size="small" @isDisabled={{this.isDisabled}}>
-        {{t "pages.attestations.download-attestations-button"}}
-      </PixButton>
-    </form>
+      <form class="attestations-page__action" {{on "submit" this.onSubmit}}>
+        <PixMultiSelect
+          @isSearchable={{true}}
+          @options={{@divisions}}
+          @values={{this.selectedDivisions}}
+          @onChange={{this.onSelectDivision}}
+          @placeholder={{t "common.filters.placeholder"}}
+        >
+          <:label>{{t "pages.attestations.select-label"}}</:label>
+          <:default as |option|>{{option.label}}</:default>
+        </PixMultiSelect>
+        <PixButton @type="submit" id="download_attestations" @size="small" @isDisabled={{this.isDisabled}}>
+          {{t "pages.attestations.download-attestations-button"}}
+        </PixButton>
+      </form>
+    {{/if}}
   </template>
 }

Diff for: orga/app/controllers/authenticated/attestations.js

@@ -15,12 +15,18 @@ export default class AuthenticatedAttestationsController extends Controller {
   @action
   async downloadSixthGradeAttestationsFile(selectedDivisions) {
     try {
+      let url;
       const organizationId = this.currentUser.organization.id;
-      const formatedDivisionsForQuery = selectedDivisions
-        .map((division) => `divisions[]=${encodeURIComponent(division)}`)
-        .join('&');
+      const baseUrl = `/api/organizations/${organizationId}/attestations/${SIXTH_GRADE_ATTESTATION_KEY}`;
+      if (selectedDivisions.length > 0) {
+        const formatedDivisionsForQuery = selectedDivisions
+          .map((division) => `divisions[]=${encodeURIComponent(division)}`)
+          .join('&');
 
-      const url = `/api/organizations/${organizationId}/attestations/${SIXTH_GRADE_ATTESTATION_KEY}?${formatedDivisionsForQuery}`;
+        url = baseUrl + `?${formatedDivisionsForQuery}`;
+      } else {
+        url = baseUrl;
+      }
 
       const token = this.session.isAuthenticated ? this.session.data.authenticated.access_token : '';
 

Diff for: orga/app/routes/authenticated/attestations.js

@@ -12,8 +12,10 @@ export default class AuthenticatedAttestationsRoute extends Route {
   }
 
   async model() {
-    const divisions = await this.currentUser.organization.divisions;
-    const options = divisions.map(({ name }) => ({ label: name, value: name }));
-    return { options };
+    if (this.currentUser.organization.isManagingStudents) {
+      const divisions = await this.currentUser.organization.divisions;
+      const options = divisions.map(({ name }) => ({ label: name, value: name }));
+      return { options };
+    }
   }
 }

Diff for: orga/tests/integration/components/attestations/sixth-grade-test.gjs

@@ -10,61 +10,99 @@ import setupIntlRenderingTest from '../../../helpers/setup-intl-rendering';
 module('Integration | Component | Attestations | Sixth-grade', function (hooks) {
   setupIntlRenderingTest(hooks);
 
-  test('it should display all basics informations', async function (assert) {
-    // given
-    const onSubmit = sinon.stub();
-    const divisions = [];
-
-    // when
-    const screen = await render(<template><SixthGrade @divisions={{divisions}} @onSubmit={{onSubmit}} /></template>);
-    // then
-    assert.ok(screen.getByRole('heading', { name: t('pages.attestations.title') }));
-    assert.ok(screen.getByText(t('pages.attestations.description')));
-    assert.ok(screen.getByRole('textbox', { name: t('pages.attestations.select-label') }));
-    assert.ok(screen.getByPlaceholderText(t('common.filters.placeholder')));
-    assert.ok(screen.getByRole('button', { name: t('pages.attestations.download-attestations-button') }));
-  });
+  module('when organization has divisions', function () {
+    test('it should display all specifics informations for divisions', async function (assert) {
+      // given
+      const onSubmit = sinon.stub();
+      const divisions = [];
+
+      // when
+      const screen = await render(<template><SixthGrade @divisions={{divisions}} @onSubmit={{onSubmit}} /></template>);
+      // then
+      assert.ok(screen.getByRole('heading', { name: t('pages.attestations.title') }));
+      assert.ok(screen.getByText(t('pages.attestations.divisions-description')));
+      assert.ok(screen.getByRole('textbox', { name: t('pages.attestations.select-label') }));
+      assert.ok(screen.getByPlaceholderText(t('common.filters.placeholder')));
+      assert.ok(screen.getByRole('button', { name: t('pages.attestations.download-attestations-button') }));
+    });
 
-  test('download button is disabled if there is no selected divisions', async function (assert) {
-    // given
-    const onSubmit = sinon.stub();
-    const divisions = [];
+    test('download button is disabled if there is no selected divisions', async function (assert) {
+      // given
+      const onSubmit = sinon.stub();
+      const divisions = [];
 
-    // when
-    const screen = await render(<template><SixthGrade @divisions={{divisions}} @onSubmit={{onSubmit}} /></template>);
+      // when
+      const screen = await render(<template><SixthGrade @divisions={{divisions}} @onSubmit={{onSubmit}} /></template>);
 
-    // then
-    const downloadButton = await screen.getByRole('button', {
-      name: t('pages.attestations.download-attestations-button'),
+      // then
+      const downloadButton = await screen.getByRole('button', {
+        name: t('pages.attestations.download-attestations-button'),
+      });
+      assert.dom(downloadButton).isDisabled();
     });
-    assert.dom(downloadButton).isDisabled();
-  });
 
-  test('it should call onSubmit action with selected divisions', async function (assert) {
-    // given
-    const onSubmit = sinon.stub();
+    test('it should call onSubmit action with selected divisions', async function (assert) {
+      // given
+      const onSubmit = sinon.stub();
 
-    const divisions = [{ label: 'division1', value: 'division1' }];
+      const divisions = [{ label: 'division1', value: 'division1' }];
 
-    // when
-    const screen = await render(<template><SixthGrade @divisions={{divisions}} @onSubmit={{onSubmit}} /></template>);
+      // when
+      const screen = await render(<template><SixthGrade @divisions={{divisions}} @onSubmit={{onSubmit}} /></template>);
 
-    const multiSelect = await screen.getByRole('textbox', { name: t('pages.attestations.select-label') });
-    await click(multiSelect);
+      const multiSelect = await screen.getByRole('textbox', { name: t('pages.attestations.select-label') });
+      await click(multiSelect);
 
-    const firstDivisionOption = await screen.findByRole('checkbox', { name: 'division1' });
-    await click(firstDivisionOption);
+      const firstDivisionOption = await screen.findByRole('checkbox', { name: 'division1' });
+      await click(firstDivisionOption);
 
-    const downloadButton = await screen.getByRole('button', {
-      name: t('pages.attestations.download-attestations-button'),
+      const downloadButton = await screen.getByRole('button', {
+        name: t('pages.attestations.download-attestations-button'),
+      });
+
+      // we need to get out of input choice to click on download button, so we have to click again on the multiselect to close it
+      await click(multiSelect);
+      await click(downloadButton);
+
+      // then
+      sinon.assert.calledWithExactly(onSubmit, ['division1']);
+      assert.ok(true);
     });
+  });
 
-    // we need to get out of input choice to click on download button, so we have to click again on the multiselect to close it
-    await click(multiSelect);
-    await click(downloadButton);
+  module('when organization does not have divisions', function () {
+    test('it should display all basics informations', async function (assert) {
+      // given
+      const onSubmit = sinon.stub();
+      const divisions = undefined;
 
-    // then
-    sinon.assert.calledWithExactly(onSubmit, ['division1']);
-    assert.ok(true);
+      // when
+      const screen = await render(<template><SixthGrade @divisions={{divisions}} @onSubmit={{onSubmit}} /></template>);
+      // then
+      assert.notOk(screen.queryByRole('textbox', { name: t('pages.attestations.select-label') }));
+      assert.ok(screen.getByRole('heading', { name: t('pages.attestations.title') }));
+      assert.ok(screen.getByText(t('pages.attestations.basic-description')));
+      assert.ok(screen.getByRole('button', { name: t('pages.attestations.download-attestations-button') }));
+    });
+
+    test('it should call onSubmit action with empty divisions', async function (assert) {
+      // given
+      const onSubmit = sinon.stub();
+
+      const divisions = undefined;
+
+      // when
+      const screen = await render(<template><SixthGrade @divisions={{divisions}} @onSubmit={{onSubmit}} /></template>);
+
+      const downloadButton = await screen.getByRole('button', {
+        name: t('pages.attestations.download-attestations-button'),
+      });
+
+      await click(downloadButton);
+
+      // then
+      sinon.assert.calledWithExactly(onSubmit, []);
+      assert.ok(true);
+    });
   });
 });