Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetupCommand should account for app/Config/app.php settings such as Version #81

Open
garretthyder opened this issue Jan 27, 2020 · 3 comments

Comments

@garretthyder
Copy link
Contributor

Hi @amostajo,

If a user manually configures their app.php config, or runs any set commands such as the version prior to running the setup wizard none of their settings are applied.

Example;
php ayuco set version:1.0.1
php ayuco setup
*The version on the theme/plugin template files is 1.0.0 and doesn't take the app.php config parameter.

@amostajo
Copy link
Contributor

Actually, we should display a warning if the framework has been set up and a command is run prior.

@amostajo amostajo added the bug label Jan 28, 2020
@garretthyder
Copy link
Contributor Author

The only thing I fear with limiting users with a warning instead of taking into account existing app.php is the setup command can't be used later on in development and we make the choice that people using the framework as their starting point but with customizations won't have them taken into account when starting new projects and using the setup command.
*speaking hypothetically of course but thinking if we can make it more flexible why lock it down so it's only ever usable as the first command that gets run.

@amostajo
Copy link
Contributor

The system should detect if the setup has run or not. If no setup is detected, then it should sto[ from executing any other command and should warn the user to run setup first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants