You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your enhancement related to a problem? Please describe.
I suggest reconsidering this project's approach to dev dependencies vs. dependencies.
Any production build/deployment process for a project based on WP Scaffold should have a mechanism to exclude dependencies that are not needed within the automated job -- specifically, we should be able to run npm install --production in a build script to exclude devDependencies, similarly to how we use composer install --no-dev. This can have a noticeable impact on build times wherever there are multiple dev dependencies.
I suggest differentiating dev dependencies vs. production dependencies this way:
A dev dependency is a dependency that's not needed to build, run, or deploy a production site. husky and lint-staged would fall in this category because they're local development tools. A testing library like jest would also fall in this category because, even though it's used in automated test jobs, it's not needed in the final build/deployment script that builds the production version of a project.
A production dependency is a dependency used to build, run or deploy the production version of a project. This includes 10up-toolkit, as 10up-toolkit is crucial to build any project that uses the theme or plugin from WP Scaffold.
So my suggestion is:
Keep husky and lint-staged where they are, because they're not needed for anything outside local development.
Move 10up-toolkit into dependencies
This would allow engineers to selectively run npm install --production in build/deploy scripts wherever it makes sense to do so.
Designs
No response
Describe alternatives you've considered
No response
Code of Conduct
I agree to follow this project's Code of Conduct
The text was updated successfully, but these errors were encountered:
Is your enhancement related to a problem? Please describe.
I suggest reconsidering this project's approach to dev dependencies vs. dependencies.
Any production build/deployment process for a project based on WP Scaffold should have a mechanism to exclude dependencies that are not needed within the automated job -- specifically, we should be able to run
npm install --production
in a build script to excludedevDependencies
, similarly to how we usecomposer install --no-dev
. This can have a noticeable impact on build times wherever there are multiple dev dependencies.I suggest differentiating dev dependencies vs. production dependencies this way:
So my suggestion is:
This would allow engineers to selectively run
npm install --production
in build/deploy scripts wherever it makes sense to do so.Designs
No response
Describe alternatives you've considered
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: