Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack process is killed whenever some of the integrated scripts finishes with errors, under Windows #38

Open
abuseofnotation opened this issue Feb 20, 2017 · 1 comment

Comments

@abuseofnotation
Copy link

abuseofnotation commented Feb 20, 2017

Under windows, scripts which finish with code different than 0 return errors to this callback:

https://github.com/1337programming/webpack-shell-plugin/blob/master/src/webpack-shell-plugin.js#L21

I think this is normal behaviour. From the node docs :

If a callback function is provided, it is called with the arguments (error, stdout, stderr). On success, error will be null. On error, error will be an instance of Error. The error.code property will be the exit code of the child process while error.signal will be set to the signal that terminated the process. Any exit code other than 0 is considered to be an error.

This callback throws all errors it gets.

As a result, the Webpack process is killed whenever some of the integrated scripts finishes with errors.

@abuseofnotation abuseofnotation changed the title Provide an option for catching exceptions on executed scripts. Webpack process is killed whenever some of the integrated scripts finishes with errors, under Windows Feb 20, 2017
@abuseofnotation
Copy link
Author

Do you want me to submit a PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant