Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Suggestion: Remove mochify #30

Open
mvattuone opened this issue Oct 13, 2017 · 3 comments
Open

Suggestion: Remove mochify #30

mvattuone opened this issue Oct 13, 2017 · 3 comments

Comments

@mvattuone
Copy link
Contributor

mvattuone commented Oct 13, 2017

Mochify relies on PhantomJS, which is more or less deprecated and currently doesn't support ES2015 syntax, which makes it somewhat challenging to reduce reliance on utility libraries like Underscore or Lodash. I discovered this while attempting to remove Underscore in #29 (see issue #27) -- while the merged solution does reduce overall size, it doesn't feel quite like the right fix.

There are a few ways to potentially circumvent the PhantomJS issue, but I think a good, long-lasting solution would be to remove Mochify entirely, replacing it with standalone mocha running Headless chrome, maybe using Puppeteer.

Alternatively, it might be worth submitting a PR to solve mantoni/mochify.js#159, as that would this issue for you and other uses of the library as well.

@afeld
Copy link
Contributor

afeld commented Oct 16, 2017

Sounds good! I don't think we have any strong attachment to Mochify, so would be totally open to a pull request switching over.

@mantoni
Copy link

mantoni commented Dec 5, 2017

I created an initial Mochify version which replaces PhantomJS with headless Chrome. Help with getting it over the finish line would be appreciated :)

Pull request: mantoni/mochify.js#161

@mantoni
Copy link

mantoni commented Dec 8, 2017

Mochify v5.0.0 has just been released. It uses Puppeteer to install and launch Chrome. PhantomJS has been removed entirely.
@mvattuone @afeld Please check if that works for you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants