Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Dockerfile best practices #1

Open
2-4601 opened this issue Nov 4, 2017 · 0 comments
Open

Adapt Dockerfile best practices #1

2-4601 opened this issue Nov 4, 2017 · 0 comments

Comments

@2-4601
Copy link
Owner

2-4601 commented Nov 4, 2017

Currently the Dockerfile only has the OS dependencies and a git clone from the GZDooM repository.
Compiling is done in a separate script in the ephemeral container.

Should the compiling process go to the Dockerfile too? What's the recommended practice? I tried to research this but unable to find a clear consensus. Docker does save intermediary stages after each command it runs. So in practice everything could go in the Dockerfile as changes only affect the commands after the change, i.e. the image is not built from scratch every time.

I've seen people do this both ways and I don't know which one is the best practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant