Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification for Deadlines and Schedules #942

Open
pocomane opened this issue Mar 6, 2023 · 6 comments
Open

Notification for Deadlines and Schedules #942

pocomane opened this issue Mar 6, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@pocomane
Copy link

pocomane commented Mar 6, 2023

Is your feature request related to a problem? Please describe.
I want to be alerted by upcoming deadlines and/or schedules also when the Organice window is not focused.

Describe the solution you'd like
If Organice is installed as PWA and opened in background, I would like to get notification about upcoming deadline and/or schedules. It should also respect the configured delay (i.e. if a deadline have a delay of -1h, it should be notified one ore before the actual deadline)

Describe alternatives you've considered
For now I am using another (native) app. This feature is too much important for me and I found no workarounds.

Additional context

Actually it seems strange to me that no issue is already opened for such feature. I found the pull request #798 closed with the statement that some code was already written. So probably, I just missed the feature, and this issue can just be tagged as a "Question" on how to enable such behavior. What I did is simply to add an headline in my capture.org with a deadline in few minutes. When the time arrived, it was not notified neither on my phone, neither on pc where the browser did not ask neither if it should allow or not notification from the app).

My setup is

  • Android 10 phone with Organice installed as PWA
  • Linux (Arch) pc with Gnome and Firefox; Organice opened from 200ok-ch site (clicking on the log-in button)
  • Both logged with gitlab to a repo I used for tests

EDIT - I changed the pull request reference to the correct one

@sawamotokai
Copy link

Is this feature supported? I also would love it.

@dtvillafana
Copy link

I too would benefit greatly from this feature.
@munen Are notifications from the PWA a feature that you would accept?
If so I would likely try to contribute the feature, despite no experience with React SPAs yet.

@munen
Copy link
Collaborator

munen commented Aug 12, 2024

@dtvillafana I would be happy to pull this feature in! I would also be happy to help with testing on iOS and browsers on Linux, as well as with documentation.

What are you thinking of in terms of UX? Since you said you have no experience with React, I suggest we do it in two steps:

  1. Focus on the MVP

„Just“ getting a notification whenever a SCHEDULED or DEADLINE Timestamp happens. I‘m assuming this won‘t need a whole lot of React specific idioms. I might be wrong, but it will be less than if we also add configurability in the mix.

We can already test, document and deploy this.

  1. Make this behavior configurable

Then, in a second iteration, we could make this behavior configurable. For example, I’m assuming that no one wants a notification at midnight for a SCHEDULED time of ‚2024-08-12‘. They might want to have such notifications always at 8am. For this, we can discuss a good UX, and I can help with implementing the necessary settings.

What do you think?

@dtvillafana
Copy link

@munen I think the MVP -> configurability path is a great approach. What you have proposed makes perfect sense to me.

This would be something I would have to contribute to in my free time, as is often the case with OSS. Therefore my timescale will be weeks to months. But I'm definitely motivated to do so as this would be much more convenient than alternative modes of notifications I was thinking of.

Looking forward to getting this working!

@munen
Copy link
Collaborator

munen commented Aug 13, 2024

@dtvillafana Good luck, have fun!

@munen munen added the enhancement New feature or request label Aug 13, 2024
@dtvillafana
Copy link

Finally giving this a crack.
It seems that the only way to do notifications based on time is to introduce a push notifications (which would introduce a backend).
The resources I consulted are:
Notification Triggers - Google
Periodic Background Sync - MDN
Web Workers - MDN

Web Workers and Service Workers seem to not be an option because they are killed by the browser when idle and can not push notifications when the page is backgrounded or when the PWA is not the active application.

Can anyone confirm or deny these findings from experience? I don't want to give up on that route prematurely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants