Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial zip uploads #1541

Open
aalemayhu opened this issue May 31, 2024 · 0 comments
Open

Partial zip uploads #1541

aalemayhu opened this issue May 31, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@aalemayhu
Copy link
Contributor

We are occasionally still seeing the invalid zip

Error copying file undefined: TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
Error: invalid zip data
    at unzipSync (/home/alemayhu/src/github.com/2anki/2anki.net/node_modules/fflate/lib/node.cjs:2664:13)
    at ZipHandler.build (/home/alemayhu/src/github.com/2anki/2anki.net/src/lib/anki/zip.tsx:41:32)
    at /home/alemayhu/src/github.com/2anki/2anki.net/src/usecases/uploads/GeneratePackagesUseCase.ts:41:14
    at Generator.next (<anonymous>)
    at /home/alemayhu/src/github.com/2anki/2anki.net/src/usecases/uploads/GeneratePackagesUseCase.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (/home/alemayhu/src/github.com/2anki/2anki.net/src/usecases/uploads/GeneratePackagesUseCase.js:4:12)
    at getPackagesFromZip (/home/alemayhu/src/github.com/2anki/2anki.net/src/usecases/uploads/GeneratePackagesUseCase.ts:33:29)
    at GeneratePackagesUseCase.<anonymous> (/home/alemayhu/src/github.com/2anki/2anki.net/src/usecases/uploads/GeneratePackagesUseCase.ts:97:51)
    at Generator.next (<anonymous>) {
  code: 13
}

I still think a fallback to bsdtar is better than total failure but it can not be the default.

@aalemayhu aalemayhu added the bug Something isn't working label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant