Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PURLs not properly migrated from 1.4 to 1.5 #255

Open
edwardsph opened this issue Jun 8, 2016 · 0 comments
Open

PURLs not properly migrated from 1.4 to 1.5 #255

edwardsph opened this issue Jun 8, 2016 · 0 comments

Comments

@edwardsph
Copy link
Contributor

PURLs created under 1.4 will not work under 1.5. I think there are 2 issues that possibly needed to be dealt with during migration:

  1. The Purl class is intended for simpler cases and perhaps existing PURLs (or at least those matching certain criteria need migrating to RewriteRules to maintain functionality.
  2. There has been a change in the way the regex is applied between 1.4 and 1.5. It now only applies to the URI beyond the PURL itself whereas in 1.4 it applied to the whole URI.

For example:

 <company-rdf> a calli:Purl , </callimachus/1.4/types/Purl> 
 ; calli:copy "^[^\?]+\?id=.*$ /usepa/app/pipelines/company-data.xpl?results&id={id}\nAccept: application/rdf+xml"^^xsd:string 
 ; rdfs:comment "Proxies RDF/XML from the FRS SPARQL endpoint for a company."^^xsd:string
 ; rdfs:label "company-rdf"^^xsd:string .

The only change in migration was the Purl type becoming </callimachus/1.5/types/Purl>.

When you edit this you cannot see the regex expression and the Accept header is treated as part of the target URL - the line break becomes a space.

In the case above the PURL can be replaced with a simple Purl without any regex expression and a target of /usepa/app/pipelines/company-data.xpl?results&id={id} as the query parameters are already parsed out of the query string

It may not be possible to do any automatic migration but we at least need to document the issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant