Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

使用phabricator方法 #4

Open
39Er opened this issue May 8, 2017 · 1 comment
Open

使用phabricator方法 #4

39Er opened this issue May 8, 2017 · 1 comment

Comments

@39Er
Copy link
Owner

39Er commented May 8, 2017

  • 1. 先创建个帐号,登录名密码与邮箱相同。
  • 2.  加入特定project。
  • 3.  安装arc, 见https://secure.phabricator.com/book/phabricator/article/arcanist/ 。 在Windows上安装稍微麻烦一点,具体见https://secure.phabricator.com/book/phabricator/article/arcanist_windows/
  • 4.  在工作目录,创建个随意的commit,尝试使用arc diff。第一次使用的时候会让你装证书。照着屏幕指令走就行了。
  • 5.  在arc diff的时候,在编辑器里会让你写summary, test plan, reviewers, subscribers。 前三项必须写。test plan一定要有。 Reviewers和subscribers里可以写多个人,用逗号隔开,既可以是人名(邮箱名),也可以是project名。Project名前面需要加#。
  • 6.  如果diff被接受了,直接arc land或者git push就行了
  • 7.  如果reviewer有建议,diff被拒绝,原作者需要做出改进并重新测试。然后使用 git commit --amend修改上次commit,然后再一次arc diff来更新上次的diff。  原则上没被accept的diff不允许push到remote。

提交步骤:
git add(新文件) --> arc diff --> arc land

@39Er
Copy link
Owner Author

39Er commented May 8, 2017

facebook Code Review 工具,可以搭配git或svn使用,感觉十分好用,有时间会研究下如何搭建phabrictor服务器

Repository owner locked and limited conversation to collaborators May 8, 2017
Repository owner unlocked this conversation May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant