Skip to content

Commit ea9da41

Browse files
authored
Merge pull request #316 from 3DBAG/pc-2025.08.21
Pc 2025.08.21
2 parents 216a8ef + 2f59b8a commit ea9da41

File tree

7 files changed

+14
-15
lines changed

7 files changed

+14
-15
lines changed

docker/pipeline/bag3d-core.dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM 3dgi/3dbag-pipeline-tools:2025.08.19 AS develop
1+
FROM 3dgi/3dbag-pipeline-tools:2025.08.25 AS develop
22
ARG VERSION=develop
33
ARG BAG3D_PIPELINE_LOCATION=/opt/3dbag-pipeline
44

docker/pipeline/bag3d-floors-estimation.dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM 3dgi/3dbag-pipeline-tools:2025.08.19 AS develop
1+
FROM 3dgi/3dbag-pipeline-tools:2025.08.25 AS develop
22
ARG VERSION=develop
33
ARG BAG3D_PIPELINE_LOCATION=/opt/3dbag-pipeline
44

docker/pipeline/bag3d-party-walls.dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM 3dgi/3dbag-pipeline-tools:2025.08.19 AS develop
1+
FROM 3dgi/3dbag-pipeline-tools:2025.08.25 AS develop
22
ARG VERSION=develop
33
ARG BAG3D_PIPELINE_LOCATION=/opt/3dbag-pipeline
44

docker/tools/Dockerfile

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,22 +56,23 @@ RUN bash $BAG3D_PIPELINE_LOCATION/tools-build.sh \
5656
--clean
5757

5858
ENV GDAL_DATA=$BAG3D_PIPELINE_LOCATION/tools/share/gdal
59-
ENV PROJ_DATA=/usr/share/proj
59+
ENV PROJ_DATA=$BAG3D_PIPELINE_LOCATION/tools/share/proj
6060
RUN echo $BAG3D_PIPELINE_LOCATION/tools/lib >> /etc/ld.so.conf.d/3dbag-pipeline-tools.conf
6161

6262
FROM tools AS tyler
6363
ARG JOBS=2
6464
ARG BAG3D_PIPELINE_LOCATION=/opt/3dbag-pipeline
6565

6666
COPY --from=3dgi/tyler:0.3.13 /usr/src/tyler/resources/geof /usr/src/tyler/resources/geof
67-
COPY --from=3dgi/tyler:0.3.13 /usr/local/share/proj /usr/local/share/proj
6867
COPY --from=3dgi/tyler:0.3.13 /lib/ /tyler/lib/
6968
COPY --from=3dgi/tyler:0.3.13 /lib64/ /tyler/lib64/
7069
COPY --from=3dgi/tyler:0.3.13 /usr/ /tyler/usr/
7170
COPY --from=3dgi/tyler:0.3.13 /usr/local/bin/tyler $BAG3D_PIPELINE_LOCATION/tools/bin/tyler
71+
# Include Dutch transformation grids
72+
COPY --from=3dgi/tyler:0.3.13 /usr/local/share/proj/nl_nsgi_nlgeo2018.tif $PROJ_DATA/nl_nsgi_nlgeo2018.tif
73+
COPY --from=3dgi/tyler:0.3.13 /usr/local/share/proj/nl_nsgi_rdtrans2018.tif $PROJ_DATA/nl_nsgi_rdtrans2018.tif
7274

7375
COPY --from=3dgi/tyler-multiformat:0.4.0-alpha10 /usr/src/tyler/resources/geof /usr/src/tyler/resources/geof
74-
COPY --from=3dgi/tyler-multiformat:0.4.0-alpha10 /usr/local/share/proj /usr/local/share/proj
7576
COPY --from=3dgi/tyler-multiformat:0.4.0-alpha10 /lib/ /tyler/lib/
7677
COPY --from=3dgi/tyler-multiformat:0.4.0-alpha10 /lib64/ /tyler/lib64/
7778
COPY --from=3dgi/tyler-multiformat:0.4.0-alpha10 /usr/ /tyler/usr/
@@ -102,8 +103,6 @@ ARG BAG3D_PIPELINE_LOCATION=/opt/3dbag-pipeline
102103
COPY --from=3dgi/roofer:v1.0.0-beta.3 /opt/roofer/bin/. $BAG3D_PIPELINE_LOCATION/tools/bin/
103104
COPY --from=3dgi/roofer:v1.0.0-beta.3 /opt/roofer/share/proj $BAG3D_PIPELINE_LOCATION/tools/share/proj
104105
COPY --from=3dgi/roofer:v1.0.0-beta.3 /opt/roofer/share/gdal $BAG3D_PIPELINE_LOCATION/tools/share/gdal
105-
ENV GDAL_DATA=$BAG3D_PIPELINE_LOCATION/tools/share/gdal
106-
ENV PROJ_DATA=$BAG3D_PIPELINE_LOCATION/tools/share/proj
107106

108107
# We only need this until we replace the old geoflow with roofer
109108
FROM roofer AS geoflow-old

packages/core/src/bag3d/core/assets/export/archive.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ def geopackage_nl(context):
111111
path_nl_zip = path_nl.with_suffix(".gpkg.zip")
112112
# Remove existing
113113
path_nl_zip.unlink(missing_ok=True)
114-
cmd = ["{exe}", str(path_nl_zip), str(path_nl)]
114+
cmd = ["{exe}", "--junk-paths", str(path_nl_zip), str(path_nl)]
115115
cmd = " ".join(cmd)
116116
context.resources.gdal.app.execute("sozip", cmd)
117117

packages/core/src/bag3d/core/assets/export/metadata.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ def export_index(context) -> Path:
199199
required_resource_keys={"file_store", "version"},
200200
)
201201
def metadata(context: AssetExecutionContext):
202-
"""3D BAG metadata for distribution.
202+
"""3DBAG metadata for distribution.
203203
Metadata schema follows the Dutch metadata profile for geographical data,
204204
https://geonovum.github.io/Metadata-ISO19115/.
205205
@@ -263,15 +263,15 @@ def metadata(context: AssetExecutionContext):
263263
metadata = {
264264
"identificationInfo": {
265265
"citation": {
266-
"title": "3D BAG",
266+
"title": "3DBAG",
267267
"date": date_3dbag,
268268
"dateType": "creation",
269269
"edition": version_3dbag,
270270
"identifier": uuid_3dbag,
271271
},
272-
"abstract": "De 3D BAG is een up-to-date landsdekkende dataset met 3D gebouwmodellen van Nederland. De 3D BAG is open data. Het bevat 3D modellen op verscheidene detailniveaus welke zijn gegenereerd door de combinatie van twee open datasets: de pand-gegevens uit de BAG en de hoogtegegevens uit de AHN. De 3D BAG wordt regelmatig geüpdatet met de meest recente openlijk beschikbare pand- en hoogtegegevens.",
272+
"abstract": "De 3DBAG is een up-to-date landsdekkende dataset met 3D gebouwmodellen van Nederland. De 3DBAG is open data. Het bevat 3D modellen op verscheidene detailniveaus welke zijn gegenereerd door de combinatie van twee open datasets: de pand-gegevens uit de BAG en de hoogtegegevens uit de AHN. De 3DBAG wordt regelmatig geüpdatet met de meest recente openlijk beschikbare pand- en hoogtegegevens.",
273273
"pointOfContact": {
274-
"organisationName": "3D BAG",
274+
"organisationName": "3DBAG",
275275
"contactInfo": {
276276
"address": {
277277
"country": "Nederland",
@@ -287,7 +287,7 @@ def metadata(context: AssetExecutionContext):
287287
"otherConstraints": [
288288
{
289289
"href": "http://creativecommons.org/licenses/by/4.0/?ref=chooser-v1",
290-
"text": "Naamensvermelding verplicht, 3D BAG door de 3D geoinformation onderzoeksgroep (TU Delft) en 3DGI",
290+
"text": "Naamensvermelding verplicht, 3DBAG door de 3D geoinformation onderzoeksgroep (TU Delft) en 3DGI",
291291
}
292292
],
293293
}

packages/core/src/bag3d/core/assets/export/validate.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1006,7 +1006,7 @@ def check_formats(input) -> TileResults:
10061006
specs = Specs3DBAGResource()
10071007
file_id = tile_id.replace("/", "-")
10081008
planarity_n_tol = 20.0
1009-
planarity_d2p_tol = 0.0001
1009+
planarity_d2p_tol = 0.01
10101010
snap_tol = 0.0001
10111011
cj_results = cityjson(
10121012
validation=validation,

0 commit comments

Comments
 (0)