From a230681de573e7c789ecc16739b80f5f23758d3c Mon Sep 17 00:00:00 2001
From: Deven Dayal <devend711@gmail.com>
Date: Thu, 1 Feb 2024 10:29:09 -0500
Subject: [PATCH] Don't consider partial unique index creation as making a
 column not nullable.

---
 CHANGELOG.md                                     | 1 +
 src/django_migration_linter/sql_analyser/base.py | 4 +++-
 tests/unit/test_sql_analyser.py                  | 4 ++++
 3 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0e5bb2a..6c69040 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,7 @@ Feature:
 
 Bug:
 - Don't detect 'IS NOT NULL' as backward incompatible changes (issue #263)
+- Don't consider UNIQUE INDEX creation as making a column not nullable
 
 Miscellaneous:
 
diff --git a/src/django_migration_linter/sql_analyser/base.py b/src/django_migration_linter/sql_analyser/base.py
index bc037f8..c27bfe9 100644
--- a/src/django_migration_linter/sql_analyser/base.py
+++ b/src/django_migration_linter/sql_analyser/base.py
@@ -37,7 +37,9 @@ def has_not_null_column(sql_statements: list[str], **kwargs) -> bool:
 
     for sql in sql_statements:
         if re.search("(?<!DROP )(?<!IS )NOT NULL", sql) and not (
-            sql.startswith("CREATE TABLE") or sql.startswith("CREATE INDEX")
+            sql.startswith("CREATE TABLE")
+            or sql.startswith("CREATE INDEX")
+            or sql.startswith("CREATE UNIQUE INDEX")
         ):
             not_null_column = True
         if re.search("DEFAULT.*NOT NULL", sql):
diff --git a/tests/unit/test_sql_analyser.py b/tests/unit/test_sql_analyser.py
index 0e903c0..6dbce6b 100644
--- a/tests/unit/test_sql_analyser.py
+++ b/tests/unit/test_sql_analyser.py
@@ -336,6 +336,10 @@ def test_create_index_concurrently_where(self):
         sql = 'CREATE INDEX CONCURRENTLY "index_name" ON "table_name" ("a_column") WHERE ("some_column" IS NOT NULL);'
         self.assertValidSql(sql)
 
+    def test_create_unique_index_concurrently_where(self):
+        sql = 'CREATE UNIQUE INDEX CONCURRENTLY "index_name" ON "table_name" ("a_column") WHERE ("some_column" IS NOT NULL);'
+        self.assertBackwardIncompatibleSql(sql, "ADD_UNIQUE")
+
     def test_drop_index_non_concurrently(self):
         sql = "DROP INDEX ON films"
         self.assertWarningSql(sql)