Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

--lint not loading sql_analyser option #235

Open
sondrelg opened this issue Oct 27, 2022 · 1 comment 路 May be fixed by #266
Open

--lint not loading sql_analyser option #235

sondrelg opened this issue Oct 27, 2022 · 1 comment 路 May be fixed by #266

Comments

@sondrelg
Copy link
Contributor

Hi!

Thanks for creating and maintaining this. It looks useful 馃憤

I'm in the process of getting the linter set up for my project and have run into two small issues:

  1. The django.contrib.gis.db.backends.postgis backend is not recognized. I think this could be mapped to postgresql safely, but I can't say for sure.
  2. According to the docs you can specify the sql_analyser, but this isn't recognized when running the linter using makemigrations.

For the second issue, this is how config values are loaded and propagated when calling the linter management command. The same thing is unfortunately not done in the makemigrations management command here. The result is that I'm not able to run the linter using the --diff flag 馃檪

Would you be open to fixing option 1 or 2 here? I'd really like to use MIGRATION_LINTER_OVERRIDE_MAKEMIGRATIONS 馃檹

@sondrelg
Copy link
Contributor Author

I probably have time to create a PR for either of these, but would love to know what you think before starting!

@rsmith013 rsmith013 linked a pull request Sep 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant