Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose remote search option off el-ui selects #344

Closed
carsoli opened this issue Jan 21, 2021 · 2 comments · Fixed by #565
Closed

Expose remote search option off el-ui selects #344

carsoli opened this issue Jan 21, 2021 · 2 comments · Fixed by #565
Labels
package:kotti-ui @3yourmind/kotti-ui priority:3-normal Should be fixed soon

Comments

@carsoli
Copy link
Contributor

carsoli commented Jan 21, 2021

element-ui supports remote search https://element.eleme.io/#/en-US/component/select#remote-search

Kotti needs to support accepting a remoteMethod, to be able to dynamically fetch options based on user query search

Internal Issues Blocked by This

@carsoli carsoli added package:kotti-ui @3yourmind/kotti-ui priority:3-normal Should be fixed soon labels Jan 21, 2021
@FlorianWendelborn
Copy link
Member

I think we should consider other solutions for this. The remote search feature that KtSelect had was one of the bigger reasons why it grew in complexity. We’d also ideally want a bit more UX around this than just the search itself.

My take on this:

  1. Search query should be controlled
  2. Search results should be passed via options still
  3. There should be a separate loading state for "waiting for backend" interactions (also controlled)

IMO, we should consider having separate components for this, at least to some extend. Alternatives I can think of is exposing a bit more functionality from KtField*Select so that we can wrap it in a KtField*Search or something like that.

What I want to avoid is increased complexity in usage and implementation, especially given that we still have element UI hacks to worry about already

@carsoli
Copy link
Contributor Author

carsoli commented May 31, 2022

Closed by the dedicated implementation of KtFieldSingleSelectRemote - we don't use element-ui anymore thanks to #565 and so it's closed for the multiselect

@carsoli carsoli closed this as completed May 31, 2022
@carsoli carsoli reopened this May 31, 2022
@carsoli carsoli linked a pull request May 31, 2022 that will close this issue
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:kotti-ui @3yourmind/kotti-ui priority:3-normal Should be fixed soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants