Skip to content

Commit da3ef4a

Browse files
authored
Merge pull request #5689 from rldhont/js-doc-lizmap-features-table-events
Docs - Trying to improve jsdoc event for lizmap-features-table without deprecation
2 parents f65056d + 57c54ed commit da3ef4a

File tree

1 file changed

+22
-33
lines changed

1 file changed

+22
-33
lines changed

assets/src/components/FeaturesTable.js

Lines changed: 22 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -186,17 +186,16 @@ export default class FeaturesTable extends HTMLElement {
186186
/**
187187
* When the table has been successfully displayed. The event carries the lizmap-features-table HTML element ID
188188
* @event featuresTableRendered
189-
* @property {string} elementId HTML element ID
189+
* @property {string} type features.table.rendered
190+
* @property {string} elementId HTML element ID
190191
* @property {string} itemLayerId The layer ID of the selected item
191-
*/
192-
mainEventDispatcher.dispatch({
193-
type: 'featuresTableRendered',
194-
elementId: this.id,
195-
itemLayerId: this.layerId,
196-
});
197-
198-
/**
199-
* @deprecated Since LWC 3.8.8, use "featuresTableRendered" instead.
192+
* @example
193+
* lizMap.mainEventDispatcher.addListener((lizmapEvent) => {
194+
* // Log the lizmap-features-table web component HTML element ID
195+
* console.log(`lizmap-features-table rendered, ID = ${lizmapEvent.elementId}`);
196+
* },
197+
* ['features.table.rendered']
198+
* );
200199
*/
201200
mainEventDispatcher.dispatch({
202201
type: 'features.table.rendered',
@@ -311,27 +310,18 @@ export default class FeaturesTable extends HTMLElement {
311310
/**
312311
* When the user has selected an item and highlighted it
313312
* @event featuresTableItemHighlighted
314-
* @property {string} elementId The element ID
313+
* @property {string} type features.table.item.highlighted
314+
* @property {string} elementId The element ID
315315
* @property {string} itemFeatureId The feature ID of the selected item
316-
* @property {string} itemLayerId The layer ID of the selected item
316+
* @property {string} itemLayerId The layer ID of the selected item
317317
* @example
318318
* lizMap.mainEventDispatcher.addListener((lizmapEvent) => {
319319
* // Log the lizmap-features-table web component HTML element ID
320-
* console.log(`lizmap-features-table rendered, ID = ${lizmapEvent.elementId}`);
320+
* console.log(`lizmap-features-table item highlighted, ID = ${lizmapEvent.elementId}`);
321321
* },
322-
* ['featuresTableRendered']
322+
* ['features.table.item.highlighted']
323323
* );
324324
*/
325-
mainEventDispatcher.dispatch({
326-
type: 'featuresTableItemHighlighted',
327-
elementId: this.id,
328-
itemFeatureId: activeItemFeatureId,
329-
itemLayerId: this.layerId,
330-
});
331-
332-
/**
333-
* @deprecated Since LWC 3.8.8, use "featuresTableItemHighlighted" instead
334-
*/
335325
mainEventDispatcher.dispatch({
336326
type: 'features.table.item.highlighted',
337327
elementId: this.id,
@@ -536,18 +526,17 @@ export default class FeaturesTable extends HTMLElement {
536526
/**
537527
* When the user has dropped an item in a new position
538528
* @event featuresTableItemDragged
529+
* @property {string} type features.table.item.dragged
539530
* @property {string} itemFeatureId The vector feature ID
540531
* @property {string} itemOldLineId The original line ID before dropping the item
541532
* @property {string} itemNewLineId The new line ID after dropping the item in a new position
542-
*/
543-
mainEventDispatcher.dispatch({
544-
type: 'featuresTableItemDragged',
545-
itemFeatureId: movedFeatureId,
546-
itemOldLineId: dropped.dataset.lineId,
547-
itemNewLineId: newItem.dataset.lineId
548-
});
549-
/**
550-
* @deprecated Since LWC 3.8.8, use "featuresTableItemDragged" instead
533+
* @example
534+
* lizMap.mainEventDispatcher.addListener((lizmapEvent) => {
535+
* // Log the lizmap-features-table web component HTML element ID
536+
* console.log(`lizmap-features-table item dragged, ID = ${lizmapEvent.elementId}`);
537+
* },
538+
* ['features.table.item.dragged']
539+
* );
551540
*/
552541
mainEventDispatcher.dispatch({
553542
type: 'features.table.item.dragged',

0 commit comments

Comments
 (0)