Cockpit-ZFS-Manager -- Can't configure replication.

[Newspring-ple]

---

Bug Report: Issue with Cockpit ZFS Manager Replication

Description:

I am encountering a persistent problem with the Cockpit ZFS Manager on the 45drives platform. Specifically, when attempting to adjust replication settings, the interface falsely reports successful completion. However, upon verification, no changes are evident. Additionally, there is an unwarranted behavior where clicking the replication button initiates three popup windows, necessitating closure before reaching a functional modification window. Although changes made in this final popup are reported as successful, they do not reflect in the actual ZFS configuration. This has been verified by checking the setup using 'znapzendzetup edit,' revealing no discernible alterations from the Cockpit UI.

Steps to Reproduce:

1. Navigate to the replication settings in the Cockpit ZFS Manager.
2. Attempt to modify replication settings.
3. Observe the false successful completion message.
4. Click the replication button again and note the appearance of three popup windows.
5. Close the popups to reach the final modification window.
6. Make changes and observe the reported successful completion.
7. Verify changes using 'znapzendzetup edit.' -- NO CHANGES HAPPENING

Expected Behavior:

Successful replication settings modifications should reflect in the ZFS configuration as reported by the Cockpit UI.

Actual Behavior:

Changes made through the Cockpit UI are not being applied to the ZFS configuration, despite receiving a successful completion message.

Environment:

• Cockpit ZFS Manager version:
  We tried both:
  cockpit-zfs-manager_1.3.0-3focal_all.deb
  cockpit-zfs-manager_1.3.0-5focal_all.deb

• Operating System: Ubuntu Live Server 20.04.6 & 22.04.3

• Browsers:
  Google Chrome Browser
  Firefox Browser

Additional Information:

    Hardware: Dell PowerEdge R740xd

---

[Newspring-ple]

Description

I have identified an issue while using the Cockpit replication feature in conjunction with znapzendzetup. I modified the znapzendzetup script to capture command line arguments in a temporary debug file (/tmp/znapzenddebug.txt). Here is a snippet of the modification in the script:

#!/usr/bin/perl
# Open a file handle for writing to the debug file
open my $debug_file, '>>', '/tmp/znapzenddebug.txt' or die "Cannot open debug file: $!";
# Print command line arguments to the debug file
print $debug_file "Command line arguments: @ARGV\n";

Issue

When running the Cockpit replication command with znapzendzetup, the values do not get updated, and I suspect this might be due to incorrect output string generation for the znapzendzetup command.

Steps to Reproduce

Execute the following command:

znapzendzetup create --recursive --mbuffer=/usr/bin/mbuffer --mbuffersize=1G SRC 4h=>15min,7d=>22h,4h=>15min,7d=>22h,4h=>15min,7d=>22h,4h=>15min,7d=>22h VHost_Pool/vfiles

Error Message

ERROR: dont know what to do with VHost_Pool/vfiles. check the syntax

Expected Behavior

The znapzendzetup command should execute without errors and properly interpret the provided arguments.

Debug Information

Contents of the debug file (/tmp/znapzenddebug.txt) after running the command after several runs:

root@nsc-vh1:/tmp# cat /tmp/znapzenddebug.txt 
Command line arguments: list VHost_Pool/vfiles
Command line arguments: list VHost_Pool/vfiles
Command line arguments: create --recursive --donotask --mbuffer=/usr/bin/mbuffer --mbuffersize=1G SRC 4h=>15min,7d=>1h,4h=>15min,7d=>1h,4h=>15min,7d=>1h,4h=>15min,7d=>1h,4h=>15min,7d=>1h,4h=>15min,7d=>1h,4h=>15min,7d=>1h,4h=>15min,7d=>1h VHost_Pool/vfiles
Command line arguments: list VHost_Pool
Command line arguments: list VHost_Pool/vfiles
Command line arguments: list VHost_Pool/vfiles
Command line arguments: create --recursive --donotask --mbuffer=/usr/bin/mbuffer --mbuffersize=1G SRC 4h=>15min,7d=>1h,4h=>15min,7d=>1h,4h=>15min,7d=>1h,4h=>15min,7d=>1h,4h=>15min,7d=>1h,4h=>15min,7d=>1h,4h=>15min,7d=>1h,4h=>15min,7d=>1h,4h=>15min,7d=>1h,4h=>15min,7d=>1h VHost_Pool/vfiles
Command line arguments: list VHost_Pool
Command line arguments: list VHost_Pool/vfiles
Command line arguments: list VHost_Pool
Command line arguments: list VHost_Pool/vfiles
Command line arguments: list VHost_Pool/vfiles
Command line arguments: create --recursive --donotask --mbuffer=/usr/bin/mbuffer --mbuffersize=1G SRC 4h=>15min,7d=>1h,4h=>15min,7d=>1h VHost_Pool/vfiles
Command line arguments: list VHost_Pool
Command line arguments: list VHost_Pool/vfiles
Command line arguments: list VHost_Pool/vfiles
Command line arguments: create --recursive --donotask --mbuffer=/usr/bin/mbuffer --mbuffersize=1G SRC 4h=>15min,7d=>22h,4h=>15min,7d=>22h,4h=>15min,7d=>22h,4h=>15min,7d=>22h VHost_Pool/vfiles
Command line arguments: list VHost_Pool
Command line arguments: list VHost_Pool/vfiles
Command line arguments: list VHost_Pool/vfiles
Command line arguments: create --recursive --mbuffer=/usr/bin/mbuffer --mbuffersize=1G SRC 4h= VHost_Pool/vfiles

I believe that there are many popup windows being opened at one click of the replication selection, and we get a copy of the time requirements for each, leading to a broken command string.

I placed quote marks around the plan and then got another error.

Steps to Reproduce

Execute the following command:

znapzendzetup create --recursive --donotask --mbuffer=/usr/bin/mbuffer --mbuffersize=1G SRC  "4h=>15min,7d=>1h,4h=>15min,7d=>1h" VHost_Pool/vfiles

Error Message

ERROR: retention time '4hours' already specified