Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC about (optionally) using bgpq3 to fetch data #68

Open
bbonev opened this issue Nov 9, 2019 · 2 comments
Open

RFC about (optionally) using bgpq3 to fetch data #68

bbonev opened this issue Nov 9, 2019 · 2 comments

Comments

@bbonev
Copy link
Contributor

bbonev commented Nov 9, 2019

I have noticed that certain as-set objects that include many ASNs and as-sets are quite slow to process or even yield memory error.

While running couple of simple tests with bgpq3, its performance is magnitudes faster.

What about providing a patch that detects if bgpq3 is present and using it instead of the built-in fetcher?

@nistorj
Copy link
Contributor

nistorj commented Jan 13, 2020

@bbonev you are correct, bgpq3 does process the information today a whole lot quicker, I think it may have to do with the way php handles streams of data, will look into this further.

@bbonev
Copy link
Contributor Author

bbonev commented Jun 5, 2020

Nope, I did some tests and the difference comes from parallel execution in bgpq3. Implementing parallelism is not impossible with php sockets, but I think that using bgpq3 as a back-end fetcher would be better.

I will prepare a PR as time permits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants