Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es6-port #12

Open
rajikaimal opened this issue Oct 17, 2016 · 21 comments
Open

es6-port #12

rajikaimal opened this issue Oct 17, 2016 · 21 comments

Comments

@rajikaimal
Copy link
Contributor

Port code to es6 with babel

@dhruvdutt
Copy link

Can I do it?

@rajikaimal
Copy link
Contributor Author

Sure, fork this repo, create your own branch and start working. Please use contribution guidelines provided.

@rajikaimal
Copy link
Contributor Author

@dhruvdutt just to clarify things, are you still working on this issue.

@dhruvdutt
Copy link

Sorry for the delay.
Most of the things seem alright. I'm still learning ES6. Is there anything to do except transforming normal functions into arrow functions?

@rajikaimal
Copy link
Contributor Author

It's fine, take your time, we need quality over quantity. Basically you can use arrow functions as a short hand syntax for normal functions, but you need to be careful about the context since arrow functions takes up the parent context. Also you can features like default arguments in ES6 within functions.

@rafaelklaessen
Copy link

Also worth mentioning is that ES6 has a new class syntax that's way nicer. Import and export have changed as well, you can do, for example, export class MyClass instead of modules.export = {}. Read more about it here.

@dhruvdutt
Copy link

@rafaelklaessen You can take this up if you wish.
I have been really busy lately with academics work.

@rafaelklaessen
Copy link

Okay, I will. I've never worked with React though, so it will take a while.

@rafaelklaessen
Copy link

@rajikaimal I've created a pull request with the ES6 port.

@rajikaimal
Copy link
Contributor Author

I started a review on PR #17

@dhruvdutt
Copy link

I'm reviewing too. 😸

@rafaelklaessen
Copy link

So, is my ES6 version going to be used or...?

@rajikaimal
Copy link
Contributor Author

We'll start improvements based on the work that you've done on this issue.

@rafaelklaessen
Copy link

Okay

@dilantha111
Copy link
Contributor

Hi I am interested on this. Can I start working on it ? if it's not completed.

@rafaelklaessen
Copy link

Looking at the code that I wrote back then there's plenty of room for improvement.
It's now kinda-partially ES6

@dilantha111
Copy link
Contributor

Is it on a particular branch ? Or is it already merged ? I can continue with the things you have done.

@rafaelklaessen
Copy link

It's on the es6 branch.
Do note that there's 41 new commits in master that need to be merged as well (or you can create a new branch and just redo it all)

@dilantha111
Copy link
Contributor

Okay thanks for the heads up. I will start working on them.

@shubhamkakkar
Copy link

Is the issue still open, as I am willing to do it

@rajikaimal
Copy link
Contributor Author

Hi, yes you can give a try.

@rajikaimal rajikaimal assigned rajikaimal and unassigned rajikaimal May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants