Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposals #62

Open
5 tasks
shapkarin opened this issue Jan 8, 2019 · 2 comments
Open
5 tasks

Proposals #62

shapkarin opened this issue Jan 8, 2019 · 2 comments
Labels
claimed

Comments

@shapkarin
Copy link
Collaborator

shapkarin commented Jan 8, 2019 •
edited
Loading

  • Do not use "components" folder. Some projects can use other structure (for example: src/pages) Move that to the .reactclirc
  • Rename "parent and child" to "Class" and "Function" or "Stateless" as in react docs
  • Update exist templates and add new (for example use proposal class properties and redux)
  • Better validation for prop names (not empty and not starts from space or number)
  • Do not ask question "Add propTypes" if you set at .reactclirc that you always use propTypes
@shapkarin
Copy link
Collaborator Author

@rajikaimal I do not has PR yet

@rajikaimal
Copy link
Contributor

rajikaimal commented Jan 9, 2019 •
edited
Loading

Okay 👍 my mistake.

@rajikaimal rajikaimal removed the has PR label Jan 9, 2019
@shapkarin shapkarin mentioned this issue Jun 19, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
claimed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shapkarin @rajikaimal