Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we cannot panic #7

Open
ArthurHeymans opened this issue Aug 30, 2024 · 2 comments · May be fixed by #13
Open

Make sure we cannot panic #7

ArthurHeymans opened this issue Aug 30, 2024 · 2 comments · May be fixed by #13
Assignees
@ArthurHeymans

Comments

@ArthurHeymans
Copy link
Contributor

https://docs.rs/no-panic/latest/no_panic/

Panics suck... Let's error gracefully
@ArthurHeymans ArthurHeymans self-assigned this Aug 30, 2024
@MDr164
Copy link
Collaborator

MDr164 commented Aug 30, 2024

I assume we can only guarantee our code does not panic but some embassy crates might also panic under odd hardware circumstances

@MDr164 MDr164 linked a pull request Sep 4, 2024 that will close this issue
Draft
@MDr164
Copy link
Collaborator

MDr164 commented Sep 6, 2024

We managed to provoke a panic rarely when writing large chips, might be worth looking into as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArthurHeymans ArthurHeymans

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make array access a bit safer 9elements/picoprog
2 participants
@ArthurHeymans @MDr164