Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masking results in errors. #10

Open
simonlevine opened this issue May 12, 2023 · 1 comment
Open

Masking results in errors. #10

simonlevine opened this issue May 12, 2023 · 1 comment

Comments

@simonlevine
Copy link

simonlevine commented May 12, 2023

Hi, If we introduce zeros in the mask key of a batch, the model won't run forward. I'm wondering if there is a fix for this as this breaks node_mask_select and edge_mask_select as the E_idx contains values that are invalid for slicing the nodes tensor in the encoder. Simply removing invalid indices fixes this problem but still results in unneeded computation. I was also wondering how masking should be managed in the outputs, as masked selection results in smaller final outputs and as such losses are not computed over entire inputs. Thanks

@gaozhangyang
Copy link
Contributor

Could you provide examples?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants