Skip to content
This repository has been archived by the owner on Feb 12, 2025. It is now read-only.

Enable bech32 receive address #171

Open
mikeroberts76 opened this issue Apr 1, 2019 · 7 comments
Open

Enable bech32 receive address #171

mikeroberts76 opened this issue Apr 1, 2019 · 7 comments

Comments

@mikeroberts76
Copy link

Please, with bech32 addresses fees are lower.

@mikeroberts76
Copy link
Author

Selection of "native" & "non-native" receive address for on-chain funding would be very nice

@sstone
Copy link
Member

sstone commented Apr 5, 2019

Yes we would like to support bech32 addresses (we chose p2sh-of-p2wpkh because there are still many wallets and services that don't understand bech32), but it's not scheduled yet and not that simple (how do we offer this option and migrate existing wallets, deal with pending closing txs, ....) so we cannot announce a release date.

@Iffabled
Copy link

@dpad85 sorry for mentioning you, but is there any ETA for this?

@maflcko
Copy link

maflcko commented Oct 11, 2019

As mentioned in the previous comment, this needs a major rewrite of the wallet, I think.

@cyanlink
Copy link

cyanlink commented Mar 7, 2020

@MarcoFalke I really don't think so... ACINQ already released their brand new 2nd-gen wallet called Phoenix, which will only generate Bech32 addresses. They already got corresponding libraries too. The famous wasabi wallet featuring CoinJoin only scans/recognizes Bech32 Addresses. Even BLW (Bitcoin Lightning Wallet, also present on bitcoin.org's wallet list, with only 1 major contributor) generates Bech32 addresses. Eclair mobile is (a little bit) left behind...

@dpad85
Copy link
Member

dpad85 commented Mar 9, 2020

As mentioned by @sstone in the comment above, the issue is how to migrate existing wallets to bech32. Ideally we'd have an automated migration system that would take care of that behind the scene, but that's not easy to do.

I think a fair solution would be that, from now on, every newly created wallet would be a bech32 wallet. Users willing to migrate would have to do that manually. We would have to add some instructions in the app to describe the process, which is:

  1. Make sure all channels are closed
  2. Send all funds somewhere else
  3. Reset data/uninstall
  4. Create new wallet

Also the "Restore wallet" page would need to know what kind of seed the user is trying to restore, which means adding a selection box in the UI with some very technical content that will confuse newcomers. But it's worth it.

@Kylejustknows
Copy link

why don't we treat the old p2wpk like an "old address".
The seed generates 2 private keys, one for p2wpk, one for bech32, in the background.

If the user is an old user, has fund/channel in old p2wpk, then run 2 processes, transparently dealing both, and always gives the user the bech32 receiving address as default, to promote user slowly move to bech32.

If the user is new, has no money no channel in the p2wpk private key, great! Simply run the bech32 process only from now on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants