Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the description or payer_note on the main page when paying an invoice via an offer #627

Closed
hMsats opened this issue Sep 12, 2024 · 1 comment

Comments

@hMsats
Copy link

hMsats commented Sep 12, 2024

When fetching an invoice in CLN via an offer through fetchinvoice and adding the option payer_note, then after the payment the text in payer_note is visible in the Phoenix wallet in the more detailed information under MESSAGE. However, the main page shows "No description".

When paying a fetched invoice in CLN via pay and adding the option decription, the text in description is not visible anywhere in the Phoenix wallet: not on the main page nor in the more detailed information.

Please add the payer_note or description text on the main page.

Phoenix version: 2.3.9 (android)

@dpad85
Copy link
Member

dpad85 commented Sep 16, 2024

and adding the option payer_note, then after the payment the text in payer_note is visible in the Phoenix wallet in the more detailed information under MESSAGE. However, the main page shows "No description".

That's intended, the main page only shows the payer_note if the payment comes from a contact. That's to avoid showing unwanted spams / advertising / spam.

To be more precise, when sending the payment, the contact must use the payer_key of his offer. AFAICT, that's something only Phoenix wallets lets you do, not CLN. Work is being done to specify this behaviour:

the text in description is not visible anywhere in the Phoenix wallet

There may be some confusion. The description of an invoice (Bolt11 or Bolt12) is set by the recipient when generating the invoice. If set, this description will be displayed by Phoenix.

But here you've set this description option from the sender's side. So it's likely just local information that CLN lets you attach to a payment for convenience, and which remains on your side.

If that's not the case, please re-open this issue

@dpad85 dpad85 closed this as completed Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants