Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button text should change dynamically #65

Open
bitcoinuser opened this issue Apr 29, 2020 · 5 comments
Open

Button text should change dynamically #65

bitcoinuser opened this issue Apr 29, 2020 · 5 comments
Labels
feature request New feature or request good first issue Good for newcomers

Comments

@bitcoinuser
Copy link
Contributor

Hi,

On send window the text (Paste payment request) should show if what is copied is a lightning invoice. But if what is copied is a bitcoin address, the text should be changed to (Paste bitcoin address).

photo_2020-04-29_15-24-55

@bitcoinuser
Copy link
Contributor Author

bitcoinuser commented Apr 29, 2020

And if nothing is copied on clipboard, maybe the button should be hidden. Do not appear.

@dpad85 dpad85 added the feature request New feature or request label May 13, 2020
@vincenzopalazzo
Copy link

Hi @dpad85,

Maybe this issue can contain the tag "good first issue", I think it is good to start to read the code with something to resolve. In addition, if the PRs are welcome and it issue is still unresolved, I want ask if I can take the lock about this issue. 😄

@dpad85
Copy link
Member

dpad85 commented Jul 20, 2020

Hi Vincenzo, you can take this issue if you want. I'm not a big fan of having an app watching my clipboard, I find it quite invasive. It does provide good UX for new users though!

@dpad85 dpad85 added the good first issue Good for newcomers label Jul 20, 2020
@vincenzopalazzo
Copy link

Hi @dpad85,

Thank you. I also noted that the text inside the paste button was already changed, so the next step to do is hide the button is inside the clipboard if there isn't something interesting, right?

@mautematico
Copy link
Contributor

Or maybe just disable or blur the button, so first time users notice the feature. Isn't that what already happens? I don't have my phone with me right now, but seem to remember that.

And if nothing is copied on clipboard, maybe the button should be hidden. Do not appear.

Hi @dpad85,

Thank you. I also noted that the text inside the paste button was already changed, so the next step to do is hide the button is inside the clipboard if there isn't something interesting, right?

dpad85 pushed a commit that referenced this issue Sep 15, 2021
…ctly named amountSat. This fixes the issue by renaming variable to amountMsat. (#65)

(cherry-picked from: @romainbsl, branch: feature/displayed-currency)

Co-authored-by: Romain Boisselle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants