-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button text should change dynamically #65
Comments
And if nothing is copied on clipboard, maybe the button should be hidden. Do not appear. |
Hi @dpad85, Maybe this issue can contain the tag "good first issue", I think it is good to start to read the code with something to resolve. In addition, if the PRs are welcome and it issue is still unresolved, I want ask if I can take the lock about this issue. 😄 |
Hi Vincenzo, you can take this issue if you want. I'm not a big fan of having an app watching my clipboard, I find it quite invasive. It does provide good UX for new users though! |
Hi @dpad85, Thank you. I also noted that the text inside the paste button was already changed, so the next step to do is hide the button is inside the clipboard if there isn't something interesting, right? |
Or maybe just
|
…ctly named amountSat. This fixes the issue by renaming variable to amountMsat. (#65) (cherry-picked from: @romainbsl, branch: feature/displayed-currency) Co-authored-by: Romain Boisselle <[email protected]>
Hi,
On send window the text (Paste payment request) should show if what is copied is a lightning invoice. But if what is copied is a bitcoin address, the text should be changed to (Paste bitcoin address).
The text was updated successfully, but these errors were encountered: