Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annihilation Plane no longer accepts drops #523

Open
zeng-github01 opened this issue Dec 29, 2024 · 1 comment · May be fixed by #524
Open

Annihilation Plane no longer accepts drops #523

zeng-github01 opened this issue Dec 29, 2024 · 1 comment · May be fixed by #524

Comments

@zeng-github01
Copy link

Describe the bug

After #510 Annihilation Plane will no longer accept drops under certain circumstances.

To Reproduce

Use a formation plane to throw out redstone and place obsidian. Use a clicker to make flux dust. The annihilation plane will absorb obsidian but not flux dust.

Expected behavior

Prior to this patch, Annihilation Plane would accept both

Additional context

Environment

  • Minecraft Version:
  • AE2 Version:
  • Forge Version:
@zeng-github01
Copy link
Author

@NotMyWing I reviewed #510 and found that I accidentally deleted the logic code for the plane to get the surrounding drops when destroying blocks. This is the reason for this issue. I will improve this issue when I have time.

When I looked up the enchantment implementation, I realized that it was actually manually generating drops, such as fortune. The native function provided by Forge can only get what items will be obtained from this destruction.

We need to generate the dropped items by ourselves through related functions

In #510, I chose to insert the mining results directly into AE. This led to this problem.

This is a bad implementation because it may cause incorrect behavior due to exceptions.

zeng-github01 added a commit to zeng-github01/Applied-Energistics-2 that referenced this issue Jan 2, 2025
@zeng-github01 zeng-github01 linked a pull request Jan 2, 2025 that will close this issue
zeng-github01 added a commit to zeng-github01/Applied-Energistics-2 that referenced this issue Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant