Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "waiver date" to player profile page #121

Open
toomuchpete opened this issue Apr 8, 2016 · 5 comments
Open

Add "waiver date" to player profile page #121

toomuchpete opened this issue Apr 8, 2016 · 5 comments

Comments

@toomuchpete
Copy link
Member

toomuchpete commented Apr 8, 2016

Player profile pages should display the last time a waiver was signed by the player. We should also ensure that each registration contains a waiver date for that specific registration.

@UthpalaPitawela
Copy link

I would like to work on this issue. Do I have to retrieve the waiver date from the database ?

@toomuchpete
Copy link
Member Author

Hi @UthpalaPitawela! Thanks for commenting; we'd love for you to take a look at this feature request.

As background, each User who has played in a League will have completed a Registration -- that Registration has a field on it called waiver_acceptance_date. What we'd want is the most recent waiver_acceptance_date. You can assume that the most recent Registration with a waiver_acceptance_date will have the most recent waiver_acceptance_date.

Please do let me know if there are other questions I can help with! I look forward to seeing your pull request!

@UthpalaPitawela
Copy link

Hi @toomuchpete
Thank you for the information. I have started working on this issue.

@UthpalaPitawela
Copy link

UthpalaPitawela commented Apr 12, 2017

Hi @toomuchpete
Could you please provide me the 'Registration' collection with just one row of rough data
Thank you!

@toomuchpete
Copy link
Member Author

Sure! This is the document from my most recent league registration:

{
        "_id" : ObjectId("58aa77fb13d75d91d8000169"),
        "payment_timestamps" : {

        },
        "waiver_acceptance_date" : ISODate("2017-02-20T05:00:43.341Z"),
        "league_id" : ObjectId("5889108328a3146381000002"),
        "signup_timestamp" : ISODate("2017-02-20T05:00:43.345Z"),
        "user_id" : ObjectId("4f91e8c1ec3e3052e0001428"),
        "status" : "active",
        "paid" : false,
        "g_rank_result_id" : ObjectId("58aa77ee13d75db993000167"),
        "g_rank" : 4,
        "availability" : {
                "general" : "75%",
                "attend_tourney_eos" : true
        },
        "gender" : "male",
        "player_strength" : "Thrower",
        "self_rank" : 4,
        "notes" : "",
        "user_data" : {
                "birthdate" : "1980-11-27",
                "firstname" : "Pete",
                "middlename" : "",
                "lastname" : "Holiday",
                "gender" : "male",
                "height" : 72,
                "weight" : 155
        },
        "commish_rank" : null,
        "comped" : true,
        "price" : 60,
        "updated_at" : ISODate("2017-02-20T05:00:43.358Z"),
        "created_at" : ISODate("2017-02-20T05:00:43.358Z")
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants