Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_topostats() should use new ImageGrainCrops classes #121

Open
ns-rse opened this issue Mar 4, 2025 · 0 comments
Open

load_topostats() should use new ImageGrainCrops classes #121

ns-rse opened this issue Mar 4, 2025 · 0 comments

Comments

@ns-rse
Copy link
Collaborator

ns-rse commented Mar 4, 2025

A refactor in TopoStats (see issue) switched from using the
topostats_object["image"] as input to grainstats to a newly introduced Class (ImageGrainCrops) which has two
attributes above and below which each hold a new class DirectionGrainCrops. The DirectionGrainCrops class has
two attributes, crops (a dictionary of GrainCrop classes which stores various properties about the grain such as the
mastk, image, bounding box padding and so forth) and the full_mask_tensor. The full mask tensors alone are stored in a
topostats_object["grain_tensors"]["above"] and topostats_object["grain_tensors"]["below"] but at the moment the
GrainCrop dictionaries are not saved, we will have to ensure they are saved to the HDF5 .topostats files on saving.

Because AFMReader should return the exact same object when loading a .topostats HDF5 file as that from which it
was saved we will have to ensure that all of this information is loaded and the appropriate classes are reconstructed so
that we can have entry points for grainstats, disordered_tracin, nodestats, ordered_tracing etc. to satisfy the
desire to have modular analyses available which shortens the processing and feedback loop when trying to improve
disentangling objects etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant