Add typeName member to link collections #748
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-fila
commented
Mar 10, 2025
tmadlener
reviewed
Mar 10, 2025
There was a problem hiding this comment.
Very nice. Effectively I only have one real comment.
Regarding the deprecation / removal of the linkCollTypeName and linkTypeName functions, I think it's fine to remove them, they are in a detail namespace, and once this is merged we can get rid of the usage in EDM4hep and remove them here as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
typeNamemembers tostd::string_view. Add utility to concatenatestd::string_views at compile time.typeNamestatic member to link collections.typeNamecan be checked at compilation time.linkCollTypeNameandlinkTypeNamehelper functions.ENDRELEASENOTES
Adding utility to concatenate multiple
std::string_views at compile time. Then using the utility to add missingtypeNamemember for link collections.The
linkCollTypeNameandlinkTypeNamefunctions will be now redundant so I propose to deprecate them. The only usage of them I could find is in EDM4hep in schema evolutionCloses #731