Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindings for reading particle data #328

Closed
BenWibking opened this issue Jun 1, 2024 · 7 comments
Closed

bindings for reading particle data #328

BenWibking opened this issue Jun 1, 2024 · 7 comments
Labels
component: particles Particles component: tests tests and examples enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@BenWibking
Copy link
Contributor

BenWibking commented Jun 1, 2024

Is there an appropriate C++ API that can be used to read particle data, similar to #320?

The use case is to visualize particles with plotfile-viewer: https://github.com/BenWibking/plotfile-viewer.

@BenWibking
Copy link
Contributor Author

cc @ax3l

@ax3l
Copy link
Member

ax3l commented Jun 4, 2024

cc @atmyers 😁

@ax3l ax3l added the question Further information is requested label Jun 4, 2024
@atmyers
Copy link
Member

atmyers commented Jun 4, 2024

Hi @BenWibking,

The code for reading particles is the Restart method of ParticleContainer, implemented here. There's also a test that shows how to use it here.

@BenWibking
Copy link
Contributor Author

@atmyers thanks!

@JBlaschke
Copy link
Contributor

@ax3l @BenWibking is there any progress on this? If not, what can we contribute to speed things up?

also tagging @ajnonaka, @drladiges @QuintonFis @laurensowards

@ax3l
Copy link
Member

ax3l commented Jul 3, 2024

Status is as follows: #320 merged two days ago and in 24.07 release.

The linked methods from Andrew's post are very easy to add. Please go ahead and post a PR - contributions are super welcome 💖. I am on PTO and back on July 15th, so this can totally land in 24.08 if someone takes the lead to add a few more .def method bindings and a good test 🙏

@ax3l ax3l added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed component: tests tests and examples component: particles Particles and removed question Further information is requested labels Jul 3, 2024
@BenWibking
Copy link
Contributor Author

Should be closed by #342 (except for any app-specific template instantiations).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: particles Particles component: tests tests and examples enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants