Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a=mediaclk:direct syntax #1

Open
garethsb opened this issue Jan 15, 2020 · 0 comments
Open

a=mediaclk:direct syntax #1

garethsb opened this issue Jan 15, 2020 · 0 comments

Comments

@garethsb
Copy link
Contributor

garethsb commented Jan 15, 2020 •
edited
Loading

RFC 7273 says:

direct = "direct" [ "=" 1*DIGIT ] [SP rate]
rate   = "rate=" integer "/" integer

However, the tests for this only check the first part and allow any string for the rate part.
And the makeSDP function doesn't appear to put the / and denominator in the generated value.

(I've also seen a=mediaclk:direct=0 rate=48000 in the wild.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@garethsb