Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring extractMTParams #26

Open
rbgodwin opened this issue Feb 21, 2023 · 0 comments
Open

Refactoring extractMTParams #26

rbgodwin opened this issue Feb 21, 2023 · 0 comments

Comments

@rbgodwin
Copy link
Contributor

This issue captures observations from code reviews performed as part of extending sdpoker to support ST 2110-22 (JPEG-XS). During the review it was observed that extractMTParams could do with refactoring

  • Ought to split on m= and then produce one entry for each media description,
  • currently files with e.g. two a=fmtp: lines per media description, or none (some media types don't need one), or media descriptions where the a=rtpmap: line comes after the a=fmtp: line rather than before, will produce unexpected results
@rbgodwin rbgodwin mentioned this issue Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant