From 82453aee34c8555489d6f7b62098c8c224d99ac7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?D=C5=BEenan=20Zuki=C4=87?= <dzenan.zukic@kitware.com>
Date: Thu, 11 Jan 2024 14:57:04 -0500
Subject: [PATCH] COMP: Fix compile warnings: discarding return value with
 [[nodiscard]]

Example message:

C:\Dev\ANTs\ImageRegistration\itkAvantsMutualInformationRegistrationFunction.cxx(368,54): warning C4834: discarding return value of function with [[nodiscard]] attribute [C:\Dev\ANTs-SB\ANTS-build\Examples\l_ANTS.vcxproj]
---
 .../ANTSUseLandmarkImagesToGetBSplineDisplacementField.cxx    | 2 +-
 Examples/antsLandmarkBasedTransformInitializer.cxx            | 4 ++--
 .../itkAvantsMutualInformationRegistrationFunction.cxx        | 2 +-
 .../antsHistogramParzenWindowsListSampleFunction.hxx          | 2 +-
 ...ntHistogramParzenShapeAndOrientationListSampleFunction.hxx | 4 ++--
 Utilities/itkSurfaceImageCurvature.hxx                        | 2 +-
 Utilities/itkWarpImageMultiTransformFilter.hxx                | 2 +-
 7 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/Examples/ANTSUseLandmarkImagesToGetBSplineDisplacementField.cxx b/Examples/ANTSUseLandmarkImagesToGetBSplineDisplacementField.cxx
index 306ed9e07..d49570fd3 100644
--- a/Examples/ANTSUseLandmarkImagesToGetBSplineDisplacementField.cxx
+++ b/Examples/ANTSUseLandmarkImagesToGetBSplineDisplacementField.cxx
@@ -283,7 +283,7 @@ LandmarkBasedDisplacementFieldTransformInitializer(int argc, char * argv[])
         }
 
         itk::ContinuousIndex<double, ImageDimension> fixedCidx;
-        fixedImage->TransformPhysicalPointToContinuousIndex(fixedPhysicalPoint, fixedCidx);
+        fixedCidx = fixedImage->TransformPhysicalPointToContinuousIndex(fixedPhysicalPoint);
 
         typename DisplacementFieldType::PointType fieldPoint;
         parametricInputImage->TransformContinuousIndexToPhysicalPoint(fixedCidx, fieldPoint);
diff --git a/Examples/antsLandmarkBasedTransformInitializer.cxx b/Examples/antsLandmarkBasedTransformInitializer.cxx
index e7f1a4a90..2b6819807 100644
--- a/Examples/antsLandmarkBasedTransformInitializer.cxx
+++ b/Examples/antsLandmarkBasedTransformInitializer.cxx
@@ -372,10 +372,10 @@ InitializeBSplineTransform(int argc, char * argv[])
         }
 
         itk::ContinuousIndex<double, ImageDimension> fixedCidx;
-        fixedImage->TransformPhysicalPointToContinuousIndex(fixedPhysicalPoint, fixedCidx);
+        fixedCidx = fixedImage->TransformPhysicalPointToContinuousIndex(fixedPhysicalPoint);
 
         typename DisplacementFieldType::PointType fieldPoint;
-        parametricInputImage->TransformContinuousIndexToPhysicalPoint(fixedCidx, fieldPoint);
+        fieldPoint = parametricInputImage->TransformContinuousIndexToPhysicalPoint(fixedCidx);
 
         fieldPoints->SetPoint(count, fieldPoint);
         fieldPoints->SetPointData(count, vector);
diff --git a/ImageRegistration/itkAvantsMutualInformationRegistrationFunction.cxx b/ImageRegistration/itkAvantsMutualInformationRegistrationFunction.cxx
index a11f1ee3f..5c0aeee78 100644
--- a/ImageRegistration/itkAvantsMutualInformationRegistrationFunction.cxx
+++ b/ImageRegistration/itkAvantsMutualInformationRegistrationFunction.cxx
@@ -365,7 +365,7 @@ AvantsMutualInformationRegistrationFunction<TFixedImage, TMovingImage, TDisplace
       this->ComputeJointPDFPoint(fixedImageValue, movingImageValue, jointPDFpoint);
       JointPDFIndexType jointPDFIndex;
       jointPDFIndex.Fill(0);
-      this->m_JointPDF->TransformPhysicalPointToIndex(jointPDFpoint, jointPDFIndex);
+      jointPDFIndex = this->m_JointPDF->TransformPhysicalPointToIndex(jointPDFpoint);
       this->m_JointPDF->SetPixel(jointPDFIndex, this->m_JointPDF->GetPixel(jointPDFIndex) + 1);
 
       ++nSamples;
diff --git a/ImageSegmentation/antsHistogramParzenWindowsListSampleFunction.hxx b/ImageSegmentation/antsHistogramParzenWindowsListSampleFunction.hxx
index 72d9d8e71..5f90b0706 100644
--- a/ImageSegmentation/antsHistogramParzenWindowsListSampleFunction.hxx
+++ b/ImageSegmentation/antsHistogramParzenWindowsListSampleFunction.hxx
@@ -136,7 +136,7 @@ HistogramParzenWindowsListSampleFunction<TListSample, TOutput, TCoordRep>::SetIn
       point[0] = inputMeasurement[d];
 
       ContinuousIndex<double, 1> cidx;
-      this->m_HistogramImages[d]->TransformPhysicalPointToContinuousIndex(point, cidx);
+      cidx = this->m_HistogramImages[d]->TransformPhysicalPointToContinuousIndex(point);
 
       typename HistogramImageType::IndexType idx;
 
diff --git a/ImageSegmentation/antsJointHistogramParzenShapeAndOrientationListSampleFunction.hxx b/ImageSegmentation/antsJointHistogramParzenShapeAndOrientationListSampleFunction.hxx
index f73c67bdd..418807946 100644
--- a/ImageSegmentation/antsJointHistogramParzenShapeAndOrientationListSampleFunction.hxx
+++ b/ImageSegmentation/antsJointHistogramParzenShapeAndOrientationListSampleFunction.hxx
@@ -98,7 +98,7 @@ JointHistogramParzenShapeAndOrientationListSampleFunction<TListSample, TOutput,
   shapePoint[1] = eigenvalue2 * (this->m_NumberOfShapeJointHistogramBins - 1);
 
   ContinuousIndex<double, 2> shapeCidx;
-  this->m_JointHistogramImages[0]->TransformPhysicalPointToContinuousIndex(shapePoint, shapeCidx);
+  shapeCidx = this->m_JointHistogramImages[0]->TransformPhysicalPointToContinuousIndex(shapePoint);
 
   typedef typename JointHistogramImageType::IndexType JointHistogramImageIndexType;
   JointHistogramImageIndexType                        shapeIdx;
@@ -272,7 +272,7 @@ JointHistogramParzenShapeAndOrientationListSampleFunction<TListSample, TOutput,
     static_cast<RealType>(this->m_NumberOfOrientationJointHistogramBins - 1));
 
   ContinuousIndex<double, 2> orientCidx;
-  this->m_JointHistogramImages[whichHistogram]->TransformPhysicalPointToContinuousIndex(orientPoint, orientCidx);
+  orientCidx = this->m_JointHistogramImages[whichHistogram]->TransformPhysicalPointToContinuousIndex(orientPoint);
 
   typedef typename JointHistogramImageType::IndexType JointHistogramImageIndexType;
   JointHistogramImageIndexType                        orientIdx;
diff --git a/Utilities/itkSurfaceImageCurvature.hxx b/Utilities/itkSurfaceImageCurvature.hxx
index cff4b1dd9..d98c11458 100644
--- a/Utilities/itkSurfaceImageCurvature.hxx
+++ b/Utilities/itkSurfaceImageCurvature.hxx
@@ -163,7 +163,7 @@ SurfaceImageCurvature<TSurface>::FindEuclideanNeighborhood(
   tempp[0] = rootpoint[0];
   tempp[1] = rootpoint[1];
   tempp[2] = rootpoint[2];
-  this->m_FunctionImage->TransformPhysicalPointToIndex(tempp, oindex);
+  oindex = this->m_FunctionImage->TransformPhysicalPointToIndex(tempp);
   for (unsigned int i = 0; i < ImageDimension; i++)
   {
     rad[i] = (long)(m_NeighborhoodRadius/this->m_Spacing[i]+0.5);
diff --git a/Utilities/itkWarpImageMultiTransformFilter.hxx b/Utilities/itkWarpImageMultiTransformFilter.hxx
index 81bb28e4c..28e81134e 100644
--- a/Utilities/itkWarpImageMultiTransformFilter.hxx
+++ b/Utilities/itkWarpImageMultiTransformFilter.hxx
@@ -540,7 +540,7 @@ WarpImageMultiTransformFilter<TInputImage, TOutputImage, TDisplacementField, TTr
           // use continous coordinates
           typename DefaultVectorInterpolatorType::ContinuousIndexType contind;
           // use ITK implementation to use orientation header
-          fieldPtr->TransformPhysicalPointToContinuousIndex(point1, contind);
+          contind = fieldPtr->TransformPhysicalPointToContinuousIndex(point1);
 
           isinside = fieldPtr->GetLargestPossibleRegion().IsInside(contind);