Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure fails due to format of test statement #66

Closed
JustScreaming opened this issue Nov 21, 2024 · 3 comments · Fixed by #69
Closed

Configure fails due to format of test statement #66

JustScreaming opened this issue Nov 21, 2024 · 3 comments · Fixed by #69
Labels

Comments

@JustScreaming
Copy link

I am trying to compile an apptainer using debian:bullseye-slim. The addition of this statement in the configure file stops the compilation

if [[ uname -eq Darwin ]] ; then
compflags=" ${compflags} -isystem /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1 -stdlib=libc++ "
fi

as it always equals true. The first test

This format of check works for the bash shells I have tested.

if [[ uname == 'Darwin' ]] ; then echo hey ;fi

@stnava
Copy link
Member

stnava commented Nov 21, 2024

pull request - and please check for other locations where this may happen

@cookpa cookpa added the bug label Nov 21, 2024
@cookpa
Copy link
Member

cookpa commented Nov 21, 2024

I can take a look later, but if you could review the script and make a PR @JustScreaming it would be great, and you can then be credited as a contributor to the project.

@JustScreaming
Copy link
Author

@cookpa I think I've done the correct things to put in a PR. I've not do that before, first time for everything :)

@cookpa cookpa linked a pull request Nov 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants