Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 16 support #64

Open
karland opened this issue Nov 13, 2017 · 2 comments
Open

React 16 support #64

karland opened this issue Nov 13, 2017 · 2 comments

Comments

@karland
Copy link

karland commented Nov 13, 2017

Very good library. Thank you.

At the moment it does not yet support React 16 for objects as params:
https://github.com/APSL/redux-i18n/blob/master/src/getTranslateFunction.js#L26-L32

See PR #63.

@francescarpi
Copy link
Member

Hi,

thank you so much for your suggest. I will take a look how improve it.

Best regards

@karland
Copy link
Author

karland commented Nov 14, 2017

Excellent. Have a look at the demoCRA and you will see that the output from

Translation 2:{" "}
<span
  dangerouslySetInnerHTML={{
    __html: this.context.t("Hello {name}!", { name: name })
  }}
/>

is

Translation 2: [object Object]

PS: Maybe you want to also update the dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants