From 4523747dbde9c9129727a9238e16339b3867edf5 Mon Sep 17 00:00:00 2001 From: AUDO Date: Fri, 7 Aug 2026 13:26:14 +0800 Subject: [PATCH 1/2] fix(scripts): stop dev:desktop leaving vite running after the window closes concurrently was started without -k, so the two children were independent: closing the Electron window ended only Electron, and vite kept listening on 5173 until the terminal itself was closed. The next `npm run dev:desktop` then failed with "Port 5173 is already in use" against a server the user had no idea was still up. The thumbs script already passes -k for the same reason. Match it here. Co-Authored-By: Claude Opus 5 --- avatar/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/avatar/package.json b/avatar/package.json index 30f67d1..af80a0c 100644 --- a/avatar/package.json +++ b/avatar/package.json @@ -10,7 +10,7 @@ "main": "electron/main.cjs", "scripts": { "dev": "vite", - "dev:desktop": "concurrently -n vite,electron -c cyan,magenta \"vite --port 5173 --strictPort\" \"wait-on http://localhost:5173 && cross-env VITE_DEV_SERVER_URL=http://localhost:5173 electron .\"", + "dev:desktop": "concurrently -n vite,electron -c cyan,magenta -k \"vite --port 5173 --strictPort\" \"wait-on http://localhost:5173 && cross-env VITE_DEV_SERVER_URL=http://localhost:5173 electron .\"", "thumbs": "concurrently -n vite,electron -c cyan,magenta -k --success first \"vite --port 5174 --strictPort\" \"wait-on http://localhost:5174 && cross-env AVATAR_GEN_THUMBS=1 VITE_DEV_SERVER_URL=http://localhost:5174 electron .\"", "desktop": "npm run build && cross-env NODE_ENV=production electron .", "build": "vite build", From b746f27116101340a6381256abe2cfbd1491b5cf Mon Sep 17 00:00:00 2001 From: rosspeili Date: Fri, 7 Aug 2026 14:02:49 +0300 Subject: [PATCH 2/2] docs: note dev:desktop concurrently -k teardown in changelog (#37, #38) --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3b4b733..38c2720 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,6 +22,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/). - Capture the Three.js group once in `VrmAvatar` so effect cleanup detaches from the same container the model was attached to (avoids orphan scenes on avatar swap). (#34) - Drop unused `audioFile` prop from `VoicePanel` (file input is uncontrolled). (#34) +- `npm run dev:desktop` now passes `concurrently -k` so closing the Electron window (or killing Vite) tears down both processes and frees port 5173. (#37, #38) ## [0.5.0] — 2026-08-06