Open
Conversation
kimyw1018
requested review from
2ghrms,
BAEK0111,
eeeeeaaan,
leesumin0526 and
sjhwang0
2ghrms
approved these changes
Feb 5, 2026
|
|
||
| private String detailAddress; | ||
|
|
||
| private String signUrl; |
Member
There was a problem hiding this comment.
이거 이미지로 입력받는거니까 signImageUrl로 명시해줍시다
| @Column(nullable = false) | ||
| private Double longitude; | ||
|
|
||
| public void setMember(Member member) { |
Member
There was a problem hiding this comment.
@Setter가 생성해주는 메소드와 겹치니, 해당 메소드를 사용하는 상황에 맞추어서 메소드 명을 변경해주면 좋을 것 같습니다
| @@ -87,7 +82,7 @@ | |||
| List<StoreUsageWithPaper> findUsageByStoreIncludingZero(@Param("adminId") Long adminId); | |||
|
|
|||
| interface StoreUsageWithPaper { | |||
Member
There was a problem hiding this comment.
유지보수를 고려하여서 record 기반의 DTO로 리팩토링합시다
| JOIN paper p ON p.id = pc.paper_id | ||
| WHERE p.admin_id = :adminId | ||
| AND pu.created_at >= CURRENT_DATE | ||
| AND pu.created_at < CURRENT_DATE + INTERVAL 1 DAY |
Member
There was a problem hiding this comment.
이거 CURRENT_DATE가 서버시간 기준이므로 혹시 UTC가 안맞을 것을 대비해서 JPQL로 변수를 입력받는 것으로 변경해주세
| private ReportedStatus status = ReportedStatus.NORMAL; | ||
|
|
||
| // 상태 업데이트 메서드 | ||
| public List<ReviewPhoto> getImageList() { |
| @Builder | ||
| @Getter | ||
| public static class todayBest{ | ||
| public static class TodayBest{ |
Member
There was a problem hiding this comment.
DTO 컨벤션에 따라서 클래스명을 ~DTO로 수정하고 record 로 수정합시다
Contributor
There was a problem hiding this comment.
마자여 record로 수정 안 된 부분들 반영 부탁드립니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
🔎코드 설명(스크린샷(선택))
💬고민사항 및 리뷰 요구사항 (Optional)
비고 (Optional)