Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reaction Threshold less than OR less than or equal to #15

Open
gwm17 opened this issue Jun 4, 2024 · 1 comment
Open

Reaction Threshold less than OR less than or equal to #15

gwm17 opened this issue Jun 4, 2024 · 1 comment
Assignees

Comments

@gwm17
Copy link
Member

gwm17 commented Jun 4, 2024

In reaction threshold check, currently say

outgoing_mass < E_cm

which is technically incorrect. Should be

outgoing_mass <= E_cm

However, the normal way to handle an equal to comp with floating points is to define a tolerance for them to be equal. Unfortunately, we have an issue where rn we are expressing the entire kinematics calculation as infinitely precise. So we can only do <= in the very literal sense. We should maybe define a precision for the simulation? Or not? Idk. The temp fix is the < instead of <=, which will generally yield the correct results. But this is kind of an annoying problem that we need to address.

@gwm17
Copy link
Member Author

gwm17 commented Jun 4, 2024

Basically, to do this correctly, we need to define the simulation precision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants