Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Split conditioning for lower VRAM usage + better performance #516

Closed
TheEnhas opened this issue Sep 15, 2022 · 4 comments

Comments

@TheEnhas
Copy link

TheEnhas commented Sep 15, 2022

Mentioned here: basujindal/stable-diffusion#168

Edit: This is not split attention but something different, if this is already in the UI then I didn't know beforehand

@JustAnOkapi
Copy link
Contributor

Edit: This is not split attention but something different, if this is already in the UI then I didn't know beforehand

def p_sample_ddim_hook(self, x_dec, cond, ts, unconditional_conditioning, *args, **kwargs):

already implemented

@JustAnOkapi
Copy link
Contributor

it was added 10 hours ago so check if you need to pull
f2693be

@JustAnOkapi
Copy link
Contributor

Mentioned here: basujindal/stable-diffusion#168

Edit: This is not split attention but something different, if this is already in the UI then I didn't know beforehand

Also is not better performance, approximately half vram usage but 40% slower.

@TheEnhas
Copy link
Author

Yeah, for some reason I was reading the inference time backwards and thought more = better, also never noticed that commit so thanks

Sashimimochi pushed a commit to Sashimimochi/stable-diffusion-webui that referenced this issue Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants