Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-D][Tester C] Duplicate Persons checked using Name #222

Closed
nus-se-bot opened this issue Apr 5, 2024 · 2 comments · Fixed by #159
Closed

[PE-D][Tester C] Duplicate Persons checked using Name #222

nus-se-bot opened this issue Apr 5, 2024 · 2 comments · Fixed by #159
Assignees
@yisiox
Labels
bug.NotAllowedToFix response.NotInScope It is a valid issue but not something the team should be penalized for severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product type.FeatureFlaw Some functionality missing from a feature delivered in v1.4 in a way that the feature becomes less u type.PlannedEnhancements Features that are planned for future development
Milestone
v1.4

Comments

@nus-se-bot
Copy link

In Singapore, names are common and there might be multiple collisions. For e.g Dave Tan might be a very common name.

Perhaps a better way to check for duplicates would be using phone numbers ?

image.png

In the screenshot you can see that 7. and 9. shares different name but have the same contact number. This shouldn't be accepted as no two person will share the same handphone number.

image.png

Labels: type.FeatureFlaw severity.Medium
original: MarcusGitty/ped#8
@aureliony aureliony added type.Bug A bug severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product labels Apr 5, 2024
@aureliony
Copy link

Related to #202.
Proposed solution is to add it to planned enhancements.

@aureliony aureliony mentioned this issue Apr 6, 2024
Closed
@aureliony
Copy link

Also add a note about name case-sensitivity

@aureliony aureliony added this to the v1.4 milestone Apr 6, 2024
@aureliony aureliony added bug.GoodToFix A bug that is good to fix, but it's fine to not fix type.FeatureFlaw Some functionality missing from a feature delivered in v1.4 in a way that the feature becomes less u response.NotInScope It is a valid issue but not something the team should be penalized for and removed type.Bug A bug labels Apr 8, 2024
@bryanyee33 bryanyee33 mentioned this issue Apr 10, 2024
Closed
@aureliony aureliony added bug.NotAllowedToFix and removed bug.GoodToFix A bug that is good to fix, but it's fine to not fix labels Apr 12, 2024
@bryanyee33 bryanyee33 added the type.PlannedEnhancements Features that are planned for future development label Apr 13, 2024
@yisiox yisiox self-assigned this Apr 15, 2024
@yisiox yisiox mentioned this issue Apr 15, 2024
Merged
@aureliony aureliony linked a pull request Apr 15, 2024 that will close this issue
Update DG for v1.4 release #159
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yisiox yisiox

Labels
bug.NotAllowedToFix response.NotInScope It is a valid issue but not something the team should be penalized for severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product type.FeatureFlaw Some functionality missing from a feature delivered in v1.4 in a way that the feature becomes less u type.PlannedEnhancements Features that are planned for future development
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

Update DG for v1.4 release AY2324S2-CS2103T-W12-3/tp
4 participants
@aureliony @nus-se-bot @bryanyee33 @yisiox