Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loot Plurals should be squashed some of the time #212

Open
AardWolf opened this issue Oct 9, 2020 · 1 comment
Open

Loot Plurals should be squashed some of the time #212

AardWolf opened this issue Oct 9, 2020 · 1 comment

Comments

@AardWolf
Copy link
Owner

AardWolf commented Oct 9, 2020

searchByItem now returns singular and plural names for loots. So a search for "cloud curd" matches cloud curd and cloud curds. They both point to the same time but the result menu makes it look like there are two matches.

@AardWolf
Copy link
Owner Author

If a loot has a plural option we will get two rows from MHCT, one for singular and one for plural. We do not know which is which. MHCT does return singulars first, then plurals. In getMHCTList we turn the response into an array then process the array.

In getLoot we could filter the results to return only the first instance of an item id that matched the term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant