refactor(plugin): separate casting logic from plugin

Author: AbdelrahmanHafez

index.js

@@ -1,33 +1 @@
-const { Query } = require('mongoose');
-const mongooseQuery = new Query();
-
-const stagesThatDoNotAffectProjection = Object.freeze(['$match', '$limit', '$sort', '$skip', '$sample']);
-
-function aggregationCastPlugin (schema) {
-  schema.pre('aggregate', function (next) {
-    const pipeline = this.pipeline();
-
-
-    for (let i = 0; i < pipeline.length; i++) {
-      const stage = pipeline[i];
-      const stageName = getStageName(stage);
-
-      const projectionHasChanged = !stagesThatDoNotAffectProjection.includes(stageName);
-      if (projectionHasChanged) return next();
-
-      if (stageName === '$match') stage[stageName] = castFilter(this._model, stage[stageName]);
-    }
-
-    next();
-  });
-}
-
-function getStageName (stage) {
-  return Object.keys(stage)[0];
-}
-
-function castFilter (Model, filter) {
-  return mongooseQuery.cast(Model, filter);
-}
-
-module.exports = aggregationCastPlugin;
+module.exports = require('./lib');

lib/cast.pipeline.js

@@ -0,0 +1,31 @@
+const { Query } = require('mongoose');
+const mongooseQuery = new Query();
+
+const stagesThatDoNotAffectProjection = Object.freeze(['$match', '$limit', '$sort', '$skip', '$sample']);
+
+function castPipeline (model, pipeline) {
+  for (const stage of pipeline) {
+    const stageName = getStageName(stage);
+
+    if (stageName === '$geoNear' && stage.$geoNear.query) {
+      castFilter(model, stage.$geoNear.query);
+    }
+
+    const projectionHasChanged = !stagesThatDoNotAffectProjection.includes(stageName);
+    if (projectionHasChanged) {
+      return;
+    }
+
+    if (stageName === '$match') stage[stageName] = castFilter(model, stage[stageName]);
+  }
+}
+
+function getStageName (stage) {
+  return Object.keys(stage)[0];
+}
+
+function castFilter (Model, filter) {
+  return mongooseQuery.cast(Model, filter);
+}
+
+module.exports = castPipeline;

lib/index.js

@@ -0,0 +1,11 @@
+const castPipeline = require('./cast.pipeline');
+
+function castAggregationPlugin (schema) {
+  schema.pre('aggregate', function () {
+    const pipeline = this.pipeline();
+
+    castPipeline(this._model, pipeline);
+  });
+}
+
+module.exports = castAggregationPlugin;