Some Nits and Issues on the Dex adapter and variable naming

[Kayanski]

Here are some issues I have with the Dex Adapter

1. The error type shouldn't be a generic but rather a type in

   abstract/framework/packages/standards/dex/src/command.rs

   Line 23 in 8882b7a

   pub trait DexCommand<E: Error = DexError>: Identify {

2. We are using AnsAsset and AssetEntry when cw_asset uses Asset and AssetInfo. Shouldn't we use similare naming, AnsAsset and AnsAssetInfo ?
3. We provide replies here but they don't seem to be used anywhere else, is that normal ?

   abstract/modules/contracts/adapters/dex/src/adapter.rs

   Lines 41 to 50 in 8882b7a

   	(
   	self.resolve_provide_liquidity(
   	deps,
   	sender,
   	assets,
   	exchange.as_mut(),
   	max_spread,
   	)?,
   	PROVIDE_LIQUIDITY,
   	)

4. All dex/staking adapters need to implement the Default trait to be able to identify them. Shouldn't be add the Default trait as a requirement for the Identify trait?

[CyberHoward]

1. and 2. are very good feedback.

2. is because of IBC. if an action is performed "over IBC" then the adapter should return an ibc callback with that ID. At least that was the idea. I think the IBC aspect of these adapters needs a major revamp, but we can do that when we get there.

3. Yes, good spot!

[kaka-acml]

Your Concern: In abstract/framework/packages/standards/dex/src/command.rs, the DexCommand trait uses a generic error type E defaulting to DexError:
rust
pub trait DexCommand<E: Error = DexError>: Identify {
You’d prefer a concrete type like DexError instead of a generic.