Skip to content

Commit 09d0cbe

Browse files
committed
Rework lambda to pass MSVC and GCC
MSVC thinks you need the capture, GCC thinks the capture is not needed, so pass variable directly into the lambda function call. Ugly to pass several booleans, but should work. Signed-off-by: Kevin Wheatley <[email protected]>
1 parent eeb461d commit 09d0cbe

File tree

1 file changed

+20
-20
lines changed

1 file changed

+20
-20
lines changed

tests/cpu/OCIOZArchive_tests.cpp

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ OCIO_ADD_TEST(OCIOZArchive, is_config_archivable)
214214
cfg->clearSearchPaths();
215215

216216
// Lambda function to facilitate adding a new FileTransform to a config.
217-
auto addFTAndTestIsArchivable = [&cfg, &minimal](const std::string & path, bool isArchivable)
217+
auto addFTAndTestIsArchivable = [&cfg](const std::string & path, bool isArchivable, bool minimal)
218218
{
219219
std::string fullPath = pystring::os::path::join(path, "fake_lut.clf");
220220
auto ft = OCIO::FileTransform::Create();
@@ -237,41 +237,41 @@ OCIO_ADD_TEST(OCIOZArchive, is_config_archivable)
237237
*/
238238

239239
// Valid FileTransform path.
240-
addFTAndTestIsArchivable("luts", true);
241-
addFTAndTestIsArchivable(R"(luts/myluts1)", true);
242-
addFTAndTestIsArchivable(R"(luts\myluts1)", true);
240+
addFTAndTestIsArchivable("luts", true, false);
241+
addFTAndTestIsArchivable(R"(luts/myluts1)", true, false);
242+
addFTAndTestIsArchivable(R"(luts\myluts1)", true, false);
243243

244244
// Valid Search path starting with "./" or ".\".
245-
addFTAndTestIsArchivable(R"(./myLuts)", true);
246-
addFTAndTestIsArchivable(R"(.\myLuts)", true);
245+
addFTAndTestIsArchivable(R"(./myLuts)", true, false);
246+
addFTAndTestIsArchivable(R"(.\myLuts)", true, false);
247247

248248
// Valid search path starting with "./" or ".\" and a context variable.
249-
addFTAndTestIsArchivable(R"(./$SHOT/myluts)", true);
250-
addFTAndTestIsArchivable(R"(.\$SHOT\myluts)", true);
251-
addFTAndTestIsArchivable(R"(luts/$SHOT)", true);
252-
addFTAndTestIsArchivable(R"(luts/$SHOT/luts1)", true);
253-
addFTAndTestIsArchivable(R"(luts\$SHOT)", true);
254-
addFTAndTestIsArchivable(R"(luts\$SHOT\luts1)", true);
249+
addFTAndTestIsArchivable(R"(./$SHOT/myluts)", true, false);
250+
addFTAndTestIsArchivable(R"(.\$SHOT\myluts)", true, false);
251+
addFTAndTestIsArchivable(R"(luts/$SHOT)", true, false);
252+
addFTAndTestIsArchivable(R"(luts/$SHOT/luts1)", true, false);
253+
addFTAndTestIsArchivable(R"(luts\$SHOT)", true, false);
254+
addFTAndTestIsArchivable(R"(luts\$SHOT\luts1)", true, false);
255255

256256
/*
257257
* Illegal scenarios
258258
*/
259259

260260
// Illegal search path starting with "..".
261-
addFTAndTestIsArchivable(R"(../luts)", false);
262-
addFTAndTestIsArchivable(R"(..\myLuts)", false);
261+
addFTAndTestIsArchivable(R"(../luts)", false, false);
262+
addFTAndTestIsArchivable(R"(..\myLuts)", false, false);
263263

264264
// Illegal search path starting with a context variable.
265-
addFTAndTestIsArchivable(R"($SHOT)", false);
265+
addFTAndTestIsArchivable(R"($SHOT)", false, false);
266266

267267
// Illegal search path with absolute path.
268-
addFTAndTestIsArchivable(R"(/luts)", false);
269-
addFTAndTestIsArchivable(R"(/$SHOT)", false);
268+
addFTAndTestIsArchivable(R"(/luts)", false, false);
269+
addFTAndTestIsArchivable(R"(/$SHOT)", false, false);
270270

271271
#ifdef _WIN32
272-
addFTAndTestIsArchivable(R"(C:\luts)", false);
273-
addFTAndTestIsArchivable(R"(C:\)", false);
274-
addFTAndTestIsArchivable(R"(\$SHOT)", false);
272+
addFTAndTestIsArchivable(R"(C:\luts)", false, false);
273+
addFTAndTestIsArchivable(R"(C:\)", false, false);
274+
addFTAndTestIsArchivable(R"(\$SHOT)", false, false);
275275
#endif
276276
}
277277
}

0 commit comments

Comments
 (0)